No objections here, constants will certainly make the code much cleaner.
Thanks
Josh Juneau
juneau001_at_gmail.com
http://jj-blogger.blogspot.com
https://www.apress.com/index.php/author/author/view/id/1866
On Fri, Jul 22, 2016 at 4:30 AM, Bauke Scholtz <balusc_at_gmail.com> wrote:
> Hi,
>
> While working on
> https://java.net/jira/browse/JAVASERVERFACES_SPEC_PUBLIC-1404 I noticed
> the strings "jsf.js" and "javax.faces" are littered throughout the API and
> impl.
>
> I propose to make them public API constants in ResourceHandler class like
> below.
>
> /**
> * <p class="changed_added_2_3">
> * Resource name of JSF script resource.
> * </p>
> *
> * @since 2.3
> */
> public static final String JSF_SCRIPT_RESOURCE_NAME = "jsf.js";
>
>
> /**
> * <p class="changed_added_2_3">
> * Library name of JSF script resource.
> * </p>
> *
> * @since 2.3
> */
> public static final String JSF_SCRIPT_LIBRARY_NAME = "javax.faces";
>
>
> I created https://java.net/jira/browse/JAVASERVERFACES_SPEC_PUBLIC-1428
> on this. If there are no objections, I will take care of it.
>
> Cheers, B
>