Gang -
A minor comment on the Flash API:
Index: javax/faces/context/Flash.java
===================================================================
--- javax/faces/context/Flash.java (revision 8845)
+++ javax/faces/context/Flash.java (revision 11719)
+ /** <p class="changed_added_2_2">Because <code>null</code>
+ * values are not allowed as the source for subclasses of
<code>EventObject</code>,
+ * such as {_at_link PostKeepFlashValueEvent} and {_at_link
PostPutFlashValueEvent},
+ * this value is substituted for <code>null</code> in the case when a
+ * <code>null</code> value is put to or kept in the flash.
+ */
+ public static final String NULL_VALUE =
"javax.faces.context.Flash.NULL_VALUE";
The "source" for these system events is the key, not the value.
Shouldn't this constant be NULL_KEY?
> * * in the case when a
> + * <code>null</code> value is put to or kept in the flash.
This should be "in the case when a null key", right?
I am a bit surprised that Flash supports null keys. Seems like the most
obvious implementation for Flash storage would be a ConcurrentHashMap,
which does not support null keys.
Andy