Hi all
Some additions.
The alternative would be to drop the call to jsf.getClientWindow entirely
like it was done before.
I am still undecided whether it is a good idea to call jsf.getClientWindow,
due to the problems it imposes with the form handling.
What do the component authors say to this, is a decoration of
jsf.getClientWindow necessary?
Werner
On Mon, Dec 3, 2012 at 11:35 AM, Werner Punz <werner.punz_at_gmail.com> wrote:
> Hi all
>
> I found an issue with the dedicated call to getClientWindow as is.
>
> javax.faces.ClientWindow Call jsf.getClientWindow(), passing the current
> form. If the return is non-null, it must be set as the value of this
> name/value pair, otherwise, a name/value pair for client window must not be
> sent.
>
>
> Now if someone decorates getClientWindow to return null, and we are in the
> fileupload case, the clientWindow always will be sent nevertheless because
> of the hidden field present.
> The same goes if there is a clientWindow hidden field present, it will be
> encoded and sent. (Note the implementation detail for the hidden field
> present case is always to alter the value of the hidden field temporarily
> before sending and reset it after sending)
>
> The better solution would be always to send the result of getClientWindow
> and in case of null sending a dedicated empty or marker string and have it
> resolved on the server as no clientWindow id. This would work in the
> fileupload case and the normal case.
>
>
>
> Werner
>
>
>
>
> On Sat, Dec 1, 2012 at 10:45 AM, Edward Burns <edward.burns_at_oracle.com>wrote:
>
>> Hello Volunteers
>>
>> I have incorporated some of your feedback into PRD RC3. [1] I still need
>> to incorporate:
>>
>> From: Leonardo Uribe <lu4242_at_gmail.com>
>> Subject: [jsr344-experts] Feedback over JSF 2.2 spec
>> Date: Wed, 28 Nov 2012 22:55:13 -0500
>>
>> From: Frank Caputo <frank_at_frankcaputo.de>
>> Subject: Re: [jsr344-experts] [ADMIN] Get your feedback resolved by 30
>> November!
>> Date: Fri, 30 Nov 2012 20:55:15 +0100
>>
>> Also, Ian and Michael took some time to comb through the commit logs
>> and summarize the spec changes. I'm going to incorporate their work
>> into the preface.
>>
>> As far as I know, the preceding are the last revisions I plan to make
>> before calling it Public Review Draft.
>>
>> If you haven't looked at the spec recently, please do take a look based
>> on [1].
>>
>> Thanks,
>>
>> Ed
>>
>> [1]
>> http://java.net/projects/javaserverfaces-spec-public/downloads/download/JSF_2_2/spec_snapshots/javax.faces-api-2.2-SNAPSHOT-20121201-javadoc.jar
>>
>> --
>> | edward.burns_at_oracle.com | office: +1 407 458 0017
>> | homepage: | http://ridingthecrest.com/
>>
>
>