As <f:viewAction> is close to <h:commandButton/Link> (It's an ActionSource2 anyway), I think:
- We should use the 'rendered' and 'disabled' attributes instead of an 'if'. While I can see the beauty of the 'if', especially as nothing "gets rendered", I think most developers are used to use 'rendered' to "disable" a component.
- viewAction should have an 'actionListener'-attribute too. (And it should also allow for "child-listener-components" - I haven't checked the source-code so far, if these would work out of the box)
Ken,
while adding the missing events is probably something we should do too. A <f:event> will never be as easy to use as a <f:viewAction action="#{....}"/> which will add the benefit, that a templateauthor/developer will not have to work with the navigationhandling directly, (s)he will just need to return an outcome as usual to change the view.
Imre
On 10.06.2011, at 20:22, Ken Paulsen wrote:
>
> After a quick look at the view action concept, I strongly agree for the need for this (closely follows what I have had in JSFT for years -- initPage event and beforeCreate event).
>
> However, I wonder if some of the details are a result of implementation limitations (missing events). I think this may be solved in a more standard-JSF-way by adding the missing events and perhaps enhancing the navigation capabilities. Then <h:event> can be used to accomplish the same -- no need for a new tag/concept.
>
> Thoughts?
>
> Ken
>
> On 06/10/2011 11:01 AM, Ed Burns wrote:
>> In my continuing drive to close out loose ends from 2.1, I am looking at
>> [758-ViewActions]
>> <http://java.net/jira/browse/JAVASERVERFACES_SPEC_PUBLIC-758>.
>>
>> Let's take the excellent work done by the Seam Faces Module team in
>> their<s:viewAction> as a point of departure. This feature is well
>> described at
>> <http://docs.jboss.org/seam/3/faces/reference/snapshot/en-US/html_single/#viewaction>.
>>
>> Does anyone have any comments on how<s:viewAction> is designed that
>> they want me to apply before putting it into the spec?
>>
>> Thanks,
>>
>> Ed