jsr344-experts@javaserverfaces-spec-public.java.net

[jsr344-experts] [SPEC-922-viewParamMaxLength] Conditional Review

From: Edward Burns <edward.burns_at_oracle.com>
Date: Thu, 28 Apr 2011 11:34:52 -0400

If anyone has a spec issue they want to fix themselves, and their judgement tells them
that it's a small-ish fix, like I have here, they are free to submit a patch to this
email list and we can start closing issues out that way.

Such threads will be in addition to the main line work listed at <jsf-spec.java.net/planning/>.
This main line work will constitute the bulk of what we do on this list, but I don't want to
restrict people if they have a simple issue they just want to see fixed, and provide a patch for it.

Note that most of the work in this patch is in correctly attributing the change to 2.2.

Remove maxlength from f:viewParam http://java.net/jira/browse/JAVASERVERFACES_SPEC_PUBLIC-922


SECTION: Modified Files
----------------------------
M jsf-api/src/main/resources/overview.html
M jsf-ri/conf/share/tlddoc-resources/stylesheet.css
M jsf-ri/conf/share/facelets_jsf_core.tld

maxlength is a passthru attribute that user agents are advised to use to
limit the allowable length a user can type in a value in a field. It
has nothing to do with server side validation. Therefore, because
f:viewParam has no immediate visual representation, this attribute is
meaningless for f:viewParam.


SECTION: Diffs
----------------------------
Index: jsf-api/src/main/resources/overview.html
===================================================================
--- jsf-api/src/main/resources/overview.html (revision 8999)
+++ jsf-api/src/main/resources/overview.html (working copy)
@@ -75,7 +75,7 @@
 
 <tr class="changed_modified_2_0">
 
-<td><span class="changed_modified_2_0_rev_a changed_modified_2_1">The API Javadocs (this document)</span></td>
+<td><span class="changed_modified_2_0_rev_a changed_modified_2_1 changed_modified_2_2">The API Javadocs (this document)</span></td>
 
 <td>generated HTML
 </td>
@@ -103,8 +103,7 @@
 
 <tr class="changed_added_2_0">
 
-<td><span class="changed_modified_2_0_rev_a changed_modified_2_1">The Facelets Taglibarydocs
-(including the new "composite" Facelets tag library)</span></td>
+<td><span class="changed_modified_2_0_rev_a changed_modified_2_1 changed_modified_2_2">The Facelets Taglibarydocs</span></td>
 
 <td><a target="_" href="../vdldocs/facelets/index.html">generated HTML</a>
 </td>
Index: jsf-ri/conf/share/tlddoc-resources/stylesheet.css
===================================================================
--- jsf-ri/conf/share/tlddoc-resources/stylesheet.css (revision 8999)
+++ jsf-ri/conf/share/tlddoc-resources/stylesheet.css (working copy)
@@ -545,7 +545,7 @@
                  text-decoration: line-through; }
 
 
-a[href^="selectItems.html"], a[href^="f/selectItems.html"], a[href^="f/tld-frame"] { cursor: url(changed_modified_2_2_cursor.cur), auto;
+a[href^="selectItems.html"], a[href^="f/selectItems.html"],a[href^="viewParam.html"], a[href^="f/viewParam.html"], a[href^="f/tld-frame"] { cursor: url(changed_modified_2_2_cursor.cur), auto;
                  background: url(changed_modified_2_2.png);
                  padding-left:0.2em; border-left:solid;
                  border-left-width:thin; border-right:none;
Index: jsf-ri/conf/share/facelets_jsf_core.tld
===================================================================
--- jsf-ri/conf/share/facelets_jsf_core.tld (revision 8999)
+++ jsf-ri/conf/share/facelets_jsf_core.tld (working copy)
@@ -2257,7 +2257,7 @@
         <description><![CDATA[
 
             <p class="changed_added_2_0"><span
- class="changed_modified_2_0_rev_a">Used</span> inside of the
+ class="changed_modified_2_0_rev_a changed_modified_2_2">Used</span> inside of the
             metada facet of a view, this tag causes a <a target="_"
             href="../../../javadocs/javax/faces/component/UIViewParameter.html">UIViewParameter</a>
             to be attached as metadata for the current view. Because
@@ -2463,24 +2463,6 @@
 
         <attribute>
             <description>
- <![CDATA[The maximum number of characters that may
- be entered in this field.]]>
- </description>
- <name>
- maxlength
- </name>
- <required>
- false
- </required>
- <deferred-value>
- <type>
- int
- </type>
- </deferred-value>
- </attribute>
-
- <attribute>
- <description>
                 The ValueExpression linking this component to a property in a backing bean
             </description>
             <name>