dev@hk2.java.net

Re: HK2-59 changes review

From: John Wells <john.wells_at_oracle.com>
Date: Thu, 31 Jan 2013 14:22:30 -0500

The changes look good to me as well. I am going to promote hk2 today,
so this change will probably be in the next promotion.

On 1/31/2013 12:37 PM, Mahesh.Kannan_at_Oracle.Com wrote:
> The changes look fine to me. Could you also run web and ejb dev tests
> with your changes?
>
> BTW, I was working on this bug and have made some progress on the
> hk2-config module (but hadn't converted the apt module). Didn't know
> that you were working on this.
>
> Mahesh
>
> On 1/31/13 9:19 AM, Iaroslav Savytskyi wrote:
>> Hi,
>>
>> I've replaced APT dependency in HK2 with JSR 269 implementation.
>>
>> Also I've removed JAXB-XJC dependency.
>>
>> This changes was tested with GF build and GF quicklook tests. I've
>> compared several generated files with old ones and they are
>> identical. Please review.
>>
>> If the changes are OK I will need the commit rights on hk2 project.
>>
>> Thanks.
>>
>> --
>> Iaroslav
>