Hi !
I would like to suggest a few improvement to the following hk2 maven
plugins:
- MavenInhabitantsGenerator.java
(hk2-inhabitant-generator:generateInhabitants)
- ConfigGeneratorPlugin.java (config-generator:generateInjectors)
The goal of the suggested changes are the following:
- avoid requiring the dependency plugin to generate classpath.txt, use
the Maven APi to get the build-classpath
- avoid requiring the helper-plugin to add additional sources directories
- avoid the use of FileFilter, instead use org.codehaus.plexus.
util.FileUtils (available as part of the Mojo API)
- introduce new File parameters to resolve the maven directories
- introduce a new parameter called "supportedProjectTypes" in order to
execute only on supported project types (default=jar)
Here are a few files attached:
- hk2-changes.diff (diff file of the hk2 changes)
- MavenInhabitantsGenerator.java and ConfigGeneratorPlugin.java (for
more readability)
- nucleus-pom-changes.diff (diff file of the nucleus pom.xml changes)
I've tested the changes against hk2 2.1.29 and successfully ran the
GlassFish build + QuickLook tests.
Please, review the changes, let me know if you have any comments or if I
can check them in for the next integration in GlassFish.
Thanks,
Romain