users@grizzly.java.net

RE: OnComplete called twice on SSLFilter

From: Ben-Yosef Efrat <Efrat.Ben-Yosef_at_comverse.com>
Date: Wed, 9 Sep 2015 08:53:23 +0000

Hi Alexey.
We are now checking this under load and we see major difference.
We run the same scenario (with SSL) and see changes in cpu and memory (65% CPU and 80% memory in the official 2.3.22 Vs. 45%cdu and 55% memory in the snapshot).

Just for you to know, we cannot run with the official 2.3.22 because we get those results. After 15 minutes the response time raises by 10000%!!!
With the snapshot, everything is relatively ok.

Is there another change or something that we need to be aware of in this snapshot? Is there something to conclude from the above results? Other changes that can be done?

Thanks
Efrat


From: Ben-Yosef Efrat
Sent: Monday, August 24, 2015 11:10 AM
To: users_at_grizzly.java.net
Subject: RE: OnComplete called twice on SSLFilter

Fixed!
Thanks a lot!

From: Oleksiy Stashok [mailto:oleksiy.stashok_at_oracle.com]
Sent: Monday, August 24, 2015 7:46 AM
To: users_at_grizzly.java.net<mailto:users_at_grizzly.java.net>
Subject: Re: OnComplete called twice on SSLFilter

Hey,

could you pls. test the latest 2.3.23-SNAPSHOT?

Thank you.

WBR,
Alexey.
On 23.08.15 02:02, Ben-Yosef Efrat wrote:
Done,
https://java.net/jira/browse/GRIZZLY-1800<http://cp.mcafee.com/d/1jWVIi4xAp3zqb35SjhOy-yqejtPqqbdQSkkkTzqqbdQSknQTzqqbdSknxPP9J555deXXXbNLToXfy7MbBGQZQ5bCvzj-ndHCvzj-ndEfEXG3X_nUsMYPtZzHTbECzBVzAm7bL3ChTkhjmKCHuX7axVZicHs3jqpJcTvAnSm4mrILECXCOsVHkiP17jeY3s4phT24qCavwi1oq184xk3BQnHTdJQ-d2Zj4fy2ycp2wEumUhQPL0QSOCU-Ur1vF6y0cg4GGH7_fPh1rjP_gd44P4Huq8aMd40Mc1knAvfUCSbCZ9mFIIQi>

Waiting for the fix :),
Thanks
Efrat

From: Oleksiy Stashok [mailto:oleksiy.stashok_at_oracle.com]
Sent: Friday, August 21, 2015 10:59 PM
To: users_at_grizzly.java.net<mailto:users_at_grizzly.java.net>
Subject: Re: OnComplete called twice on SSLFilter

Hi Efrat,

yes, please open a bug.
I'll try to fix asap.

WBR,
Alexey.
On 19.08.15 05:36, Ben-Yosef Efrat wrote:
Hi Alexey,

Thanks!
Do you need me to open a bug? When do you think I could have a fix (even a snapshot)?
Thanks

Efrat

From: Oleksiy Stashok [mailto:oleksiy.stashok_at_oracle.com]
Sent: Saturday, August 15, 2015 1:04 AM
To: users_at_grizzly.java.net<mailto:users_at_grizzly.java.net>
Subject: Re: OnComplete called twice on SSLFilter

Hi Efrat,

I see what you mean, the ssl tear down process can cause it, I'll investigate and fix.

Thanks.

WBR,
Alexey.
On 12.08.15 02:09, Ben-Yosef Efrat wrote:
Hi Alexey,

We see the following:


1. Client connects on the SSL socket - handshake is complete -> OK

2. When done, client closes and disconnect. The handleRead() is called and then:

if (sslEngine != null && !isHandshaking(sslEngine)) {

            return unwrapAll(ctx, sslCtx);



in unwrap all the following is called:



if (isHandshaking(sslCtx.getSslEngine())) {

                input = rehandshake(ctx, sslCtx);

                if (input == null) {

                    break;

                }

            }

And then the notifyHandshakeComplete() and onComplete()


I don't understand why when closing the socket and the "if" caluese states "isHandshaking == false", why the rehandshake?

Thanks
Efrat

From: Oleksiy Stashok [mailto:oleksiy.stashok_at_oracle.com]
Sent: Wednesday, August 12, 2015 10:07 AM
To: users_at_grizzly.java.net<mailto:users_at_grizzly.java.net>
Subject: Re: OnComplete called twice on SSLFilter

Hi,

well, yes on rehandshake both onStart and onComplete/onFailure will be called again.

WBR,
Alexey.
On 10.08.15 03:18, Ben-Yosef Efrat wrote:
Hello

We encounter a case in which the onComplete() in the SSLFilter is called twice (on the second time I see "rehandshake" method in the call stack).
As far as I understand, it should be called only once when the SSL handshake is complete...
Please advise,

Thanks
Efrat
________________________________
"This e-mail message may contain confidential, commercial or privileged information that constitutes proprietary information of Comverse Inc. or its subsidiaries. If you are not the intended recipient of this message, you are hereby notified that any review, use or distribution of this information is absolutely prohibited and we request that you delete all copies and contact us by e-mailing to: security_at_comverse.com<mailto:security_at_comverse.com>. Thank You."

________________________________
"This e-mail message may contain confidential, commercial or privileged information that constitutes proprietary information of Comverse Inc. or its subsidiaries. If you are not the intended recipient of this message, you are hereby notified that any review, use or distribution of this information is absolutely prohibited and we request that you delete all copies and contact us by e-mailing to: security_at_comverse.com<mailto:security_at_comverse.com>. Thank You."

________________________________
"This e-mail message may contain confidential, commercial or privileged information that constitutes proprietary information of Comverse Inc. or its subsidiaries. If you are not the intended recipient of this message, you are hereby notified that any review, use or distribution of this information is absolutely prohibited and we request that you delete all copies and contact us by e-mailing to: security_at_comverse.com<mailto:security_at_comverse.com>. Thank You."

________________________________
"This e-mail message may contain confidential, commercial or privileged information that constitutes proprietary information of Comverse Inc. or its subsidiaries. If you are not the intended recipient of this message, you are hereby notified that any review, use or distribution of this information is absolutely prohibited and we request that you delete all copies and contact us by e-mailing to: security_at_comverse.com<mailto:security_at_comverse.com>. Thank You."

________________________________
"This e-mail message may contain confidential, commercial or privileged information that constitutes proprietary information of Comverse Inc. or its subsidiaries. If you are not the intended recipient of this message, you are hereby notified that any review, use or distribution of this information is absolutely prohibited and we request that you delete all copies and contact us by e-mailing to: security_at_comverse.com. Thank You."