Salut,
Oleksiy Stashok wrote:
>>
>>> I think it's more appropriate in this mailing list.
>>> I have to snippet of codes. I,m looking for a way to optimize the
>>> ByteBuffer realocation if possible. *Part1 in ProtocolParser*
>>> // Check if buffer is full
>>> if (processingBuffer.remaining() ==
>>> processingBuffer.capacity()) {
>>> // If full - reallocate
>>> // but check if the max
>>> length is attain
>>> if(processingBuffer.capacity() +
>>> processingBuffer.remaining()<LIMITBB){
>>> ByteBuffer newBB =
>>> ByteBufferFactory.allocateView(
>>> processingBuffer.capacity() * 2,
>>> processingBuffer.isDirect());
>>> newBB.put(processingBuffer);
>>> processingBuffer = newBB;
>>> WorkerThread workerThread = (WorkerThread)
>>> Thread.currentThread();
>>> workerThread.setByteBuffer(processingBuffer);
>>
>> Why not using a ConcurrentLinkedQueue to store unused ByteBuffer
>> instance? That way you don't rely on the heap/native memory and
>> instead you can re-use the instance, or allocate larger byte buffer so
>> you don't have re-allocate.
> IMHO it's enough tricky to implement own memory management. One thing,
> if our implementation uses constant size ByteBuffer, but if not... It
> will mean, that ByteBuffer, we pool, may never be reused. Also we need
> to write additional code to control ConcurrentLinkedQueue size,
> calculate optimal size for newly allocated ByteBuffer etc... IMHO It's
> not very easy to implement.
Agree. But since we don't have anything right now, the simplest solution
would consist of using a ConcurrentLinkedQueue :-)
> In Grizzly 2.0 we will have smart Buffer management implementation, and
> I'm very curious about benefit it will bring.
Might be a good candidate for back port if we see benifits
A+
-- Jeanfrancois
>
> Thanks.
>
> WBR,
> Alexey.
>
>>
>>
>>
>> A+
>>
>> -- Jeanfrancois
>>
>>
>>
>>
>>
>>
>>
>>> } else {
>>> s_logger.info
>>> <http://s_logger.info>("BUFFER
>>> max length was reached");
>>>
>>> processingBuffer.clear();
>>>
>>> maxBufferReached = true;
>>> return
>>> maxBufferReached;
>>> }
>>> }
>>> *Part 2 sending data to the clients*
>>> public class Client ....
>>> public void sendToClient(StringBuffer sb) {
>>> ByteBuffer writeBuffer =
>>> ByteBuffer.allocateDirect(sb.toString().getBytes().length);
>>> writeBuffer.put(sb.toString().getBytes());
>>> writeBuffer.flip();
>>> ......
>>> }
>>> }
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscribe_at_grizzly.dev.java.net
>> For additional commands, e-mail: users-help_at_grizzly.dev.java.net
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe_at_grizzly.dev.java.net
> For additional commands, e-mail: users-help_at_grizzly.dev.java.net
>