users@grizzly.java.net

CometEngine.register Thread Safety

From: Dan Dubois <uvicoxpz_at_googlemail.com>
Date: Sun, 6 Jul 2008 22:21:31 +0100

*** Sorry if this is a dupe ***

Hello All,

I want to use CometEngine.register in my servlet doGet request.

However looking at the source code v1_8_0_1
(https://grizzly.dev.java.net/source/browse/grizzly/tags/1_8_0_1/modules/comet/src/main/java/com/sun/grizzly/comet/CometEngine.java?rev=1268&view=markup)
 I believe that CometEngine.register is not thread safe. Do you agree
with this?

The reason I bring this up is because I can see quite a few use cases
where one would want to register a CometContext in a multithreaded
environment, for example in a servlet event. Do you agree that it
might be good to either document the lack of thread safety of make is
threadsafe?

The main reason I am taking time to comment is because I think Grizzly
is excellent and want to help it get even better.

Best wishes,

Dan