users@grizzly.java.net

Re: ProtocolParser Advice

From: Jeanfrancois Arcand <Jeanfrancois.Arcand_at_Sun.COM>
Date: Mon, 09 Jun 2008 12:37:44 -0400

Hi John,

John ROM wrote:
> Hi Jeanfrancois Arcand
> Wow I actually didn't expect you to be so fast (8-:
>
> I have a big bug in line 209
> ByteBuffer newBuffer = ByteBufferFactory.allocateView(newCapacity, grizzlyBuffer.isDirect());
>
> this line should be replaced with :
>
> ByteBuffer newBuffer = ByteBufferFactory.allocate(ByteBufferFactory.ByteBufferType.HEAP,newCapacity);
>
>
> So in future what is the best way for me to change something in the published code.
>
> For example I want to change the javadocs and also how the bytbuffer is treated...

Just submit patch by doing:

svn diff > patch.txt

Since you are more and more involved with the community, a couple a
patches and I can propose you as a commiter :-) That way you can changes
things as you want :-)

A+

-- Jeanfrancois



>
> Many Greetings John
>
>
>
>
>
>