Hi Bongjae,
sure, I agree.
Pls. go ahead and commit the patch.
Thanks.
WBR,
Alexey.
On 01/30/2012 02:00 AM, Bongjae Chang wrote:
> Hi,
>
> This is trivial issue.
>
> We can't set HeapMemoryManager's maxBufferSize because
> HeapMemoryManager doesn't have the constructor with maxBufferSize.
> The default size is 64K.
>
> How about providing the constructor like this?
>
> ---
> In HeapMemoryManager.java
>
> public HeapMemoryManager() {
> }
>
> public HeapMemoryManager(final int maxBufferSize) {
> super(maxBufferSize);
> }
> ---
>
> Then, users can use it with a specific size.
>
> ---
> TCPNIOTransport transport = ...;
> transport.setMemoryManager( new HeapMemoryManager(1024 * 1024) );
> ---
>
> Thanks.
>
> Regards,
> Bongjae Chang