No problem. I fixed them.
I really hope you will improve and optimize it!
Thanks!
Regards,
Bongjae Chang
On 11/30/11 7:15 PM, "Oleksiy Stashok" <oleksiy.stashok_at_oracle.com> wrote:
>Hi Bongjae,
>
>thanks a lot!
>I will take a look at the code, may be will come with some ideas how we
>can improve/optimize it.
>
>Wanted to ask if you can update copyright headers according to this
>report:
>
><http://hudson-sca.us.oracle.com/job/Grizzly_2_x_Copyright_Check/ws/extras
>/thrift/src/test/java/org/glassfish/grizzly/thrift/CalculatorHandler.java>
>: Wrong copyright
><http://hudson-sca.us.oracle.com/job/Grizzly_2_x_Copyright_Check/ws/extras
>/thrift/src/test/java/shared/SharedService.java>: No copyright
><http://hudson-sca.us.oracle.com/job/Grizzly_2_x_Copyright_Check/ws/extras
>/thrift/src/test/java/shared/SharedStruct.java>: No copyright
><http://hudson-sca.us.oracle.com/job/Grizzly_2_x_Copyright_Check/ws/extras
>/thrift/src/test/java/tutorial/Calculator.java>: No copyright
><http://hudson-sca.us.oracle.com/job/Grizzly_2_x_Copyright_Check/ws/extras
>/thrift/src/test/java/tutorial/Constants.java>: No copyright
><http://hudson-sca.us.oracle.com/job/Grizzly_2_x_Copyright_Check/ws/extras
>/thrift/src/test/java/tutorial/InvalidOperation.java>: No copyright
><http://hudson-sca.us.oracle.com/job/Grizzly_2_x_Copyright_Check/ws/extras
>/thrift/src/test/java/tutorial/Operation.java>: No copyright
><http://hudson-sca.us.oracle.com/job/Grizzly_2_x_Copyright_Check/ws/extras
>/thrift/src/test/java/tutorial/Work.java>: No copyright
>++ cat copyright.out
>+ '[' -z
>'<http://hudson-sca.us.oracle.com/job/Grizzly_2_x_Copyright_Check/ws/extra
>s/thrift/src/test/java/org/glassfish/grizzly/thrift/CalculatorHandler.java
>>: Wrong copyright
><http://hudson-sca.us.oracle.com/job/Grizzly_2_x_Copyright_Check/ws/extras
>/thrift/src/test/java/shared/SharedService.java>: No copyright
><http://hudson-sca.us.oracle.com/job/Grizzly_2_x_Copyright_Check/ws/extras
>/thrift/src/test/java/shared/SharedStruct.java>: No copyright
><http://hudson-sca.us.oracle.com/job/Grizzly_2_x_Copyright_Check/ws/extras
>/thrift/src/test/java/tutorial/Calculator.java>: No copyright
><http://hudson-sca.us.oracle.com/job/Grizzly_2_x_Copyright_Check/ws/extras
>/thrift/src/test/java/tutorial/Constants.java>: No copyright
><http://hudson-sca.us.oracle.com/job/Grizzly_2_x_Copyright_Check/ws/extras
>/thrift/src/test/java/tutorial/InvalidOperation.java>: No copyright
><http://hudson-sca.us.oracle.com/job/Grizzly_2_x_Copyright_Check/ws/extras
>/thrift/src/test/java/tutorial/Operation.java>: No copyright
><http://hudson-sca.us.oracle.com/job/Grizzly_2_x_Copyright_Check/ws/extras
>/thrift/src/test/java/tutorial/Work.java>: No copyright' ']'
>
>Sorry for that bureaucratic stuff :)
>
>
>Thanks.
>
>WBR,
>Alexey.
>
>On 11/30/2011 09:54 AM, Bongjae Chang wrote:
>> Hi Alexey,
>>
>> There were no problems.
>>
>> I also committed thrift's tutorial-generated codes for testing in
>> /test/java/shared and /test/java/tutorial folder(I didn't want to change
>> any generated codes of thrift for testing).
>>
>> And I resolved the issue GRIZZLY-1129.
>>
>> Additionally, I think that it will be easy to support ssl and
>>http-thrift
>> later if it will be needed.
>>
>> Thanks.
>>
>> Regards,
>> Bongjae Chang
>>
>>
>> On 11/30/11 12:21 AM, "Oleksiy Stashok"<oleksiy.stashok_at_oracle.com>
>>wrote:
>>
>>> Hi Bongjae,
>>>
>>>>> But, I *couldn't* commit test codes for maven because user-generated
>>>>> thrift codes were needed for testing(any idea?).
>>> Can you pls. give more details on this problem?
>>>
>>> Thank you.
>>>
>>> WBR,
>>> Alexey.
>>>
>>>> Regards,
>>>> Bongjae Chang
>>>>
>>>> On 11/28/11 11:17 PM, "Bongjae Chang"<bongjae.chang_at_gmail.com>
>>>>wrote:
>>>>
>>>>> Hi Alexey,
>>>>>
>>>>> I fixed bugs as your advice and committed them to extras/thrift.
>>>>>
>>>>> I edited 3 points from original sources which I attached.
>>>>>
>>>>> 1. Processing more than 1 thrift packet in ThriftFrameFilter
>>>>> 2. Adding input buffer dispose() in ThriftServerFilter
>>>>> 3. Removing redundant input buffer copy in ThriftClientFilter
>>>>>
>>>>> Commit revision is "f1d895bf".
>>>>>
>>>>> But, I could commit test codes for maven because user-generated
>>>>>thrift
>>>>> codes were needed for testing(any idea?).
>>>>>
>>>>> So you can test it in only original attached files.
>>>>>
>>>>> If there are any issues or more suggestions about this, please let me
>>>>> know.
>>>>>
>>>>> Thanks!
>>>>>
>>>>> Regards,
>>>>> Bongjae Chang
>>>>>
>>>>>
>>>>> On 11/28/11 7:29 PM, "Oleksiy Stashok"<oleksiy.stashok_at_oracle.com>
>>>>> wrote:
>>>>>
>>>>>> Hi Bongjae,
>>>>>>
>>>>>>> I implemented thrift server and client modules which based on
>>>>>>>Grizzly
>>>>>>> v2.
>>>>>> thank you very much for your contribution!
>>>>>>
>>>>>>> Thrift site is http://thrift.apache.org .
>>>>>>>
>>>>>>> And Netty is already supporting thrift server and client modules.
>>>>>>>
>>>>>>> Netty tool site is https://github.com/cgbystrom/netty-tools
>>>>>>>
>>>>>>> So I tried to support them using Grizzly for performance
>>>>>>>improvement.
>>>>>>>
>>>>>>> I attached sources and test codes. Grizzly-thrift codes are located
>>>>>>> at
>>>>>>> modules/thrift/src/main and please read the README file. :)
>>>>>>> Could you please review them?
>>>>>> Can I suggest you move this code to Grizzly git repository under
>>>>>> extras
>>>>>> directory for now, so it will simplify development for you and
>>>>>> reviewing
>>>>>> for folks who's interested.
>>>>>> The code looks fine in general.
>>>>>> The most important thing, which is probably missed (if I'm not
>>>>>>missing
>>>>>> anything), in the ThriftFrameFilter there is no logic, which handles
>>>>>> situation when input Buffer contains more than 1 thrift packet (you
>>>>>> can
>>>>>> see the GIOP sample) to see how we propose to handle this (splitting
>>>>>> buffer etc).
>>>>>>
>>>>>> Hope this will help.
>>>>>>
>>>>>> Thanks.
>>>>>>
>>>>>> WBR,
>>>>>> Alexey.
>>
>