Hi Chad,
Code looks good to me. Two comments:
- ProtobufEncoder:43 consider calling trim() vs flip() to attempt to
reclaim unused buffer space (may
not be relevant here)
- Source files (code/resources) need CDDL copyright headers.
Additionally, since this module will depend on a third-party library,
I've started the internal
approval process to have this dependency approved by legal. Hopefully
it won't take too long.
Will let you know.
On 7/13/11 9:51 AM, cdollins wrote:
> Updates to ProtobufEncoder.java have been made to make use of
> BufferOutputStream. You can find the source on
> https://github.com/cdollins/grizzly-google-protobufs github
>
> --
> View this message in context: http://grizzly.1045725.n5.nabble.com/Questions-about-Protocol-Buffer-Implementation-tp4305806p4583347.html
> Sent from the Grizzly - Development mailing list archive at Nabble.com.