hello,
DefaultProcessorTask does a AccessController.doPrivileged to get a Date
string from cache.
Is it needed only due to the static System.getProperty in the
FastHttpDateFormat ?
The default value for the cache size that is read from System.getProperty is
1000 .
Considering how this class is implemented (copy pasted) In jboss, tomcat and
until recently grizzly i can understand for the need to configure the value.
The cache is for the formatDate method storing date values with millisecond
precision.
Its a http.FastHttpDateFormat named class, hence the context usage are
http date values, that has a precision of 1 second in the spec.
If this context awareness is used when designing the cache, it can be
efficient and fast
Instead of using date values with millisecond precision, we can get away
with both parsing dates and storing them in the cache several thousand
percent less often.
The cache default size is lasting between 1 and a few seconds depending on
the precision from System.currentTimeMillis if used frequently.
it will in grizzly last for 1000 seconds = 16 minutes due to the added
code: value = (value/1000)*1000; that truncates in the same way as the
SimpleDateFormat does.
I think we we can remove the System get property, and the doPrivileged
usage (unless there are other reason for it ? ).
If more then 1000 seconds is wanted we could have a higher default value.
what is your opinion ?
--
regards
gustav trede