dev@grizzly.java.net

Re: Code changes to fix issue in logic of async execution of Jruby

From: Jeanfrancois Arcand <Jeanfrancois.Arcand_at_Sun.COM>
Date: Mon, 25 Feb 2008 20:42:40 -0500

Hi Pramod,


Pramod Gopinath wrote:
> Hi Jeanfrancois
> Sending in the diff file for this change too.
>
> Thanks
> Pramod
>
> Pramod Gopinath wrote:
>> 2 Code changes both dealing with the support of asynchronous request
>> processing (ARP) in grizzly-jruby module.
>> Think that the current timelimit provided is low, hence changing the
>> time to be 360 seconds (5 minutes). Not sure if this is large/small
>> enough. Want to know what you guys feel on that ?

That make sense.


>> Fixing the logic where the queue poll would not happen if the queue
>> has been enabled for asynchronous requests.

That one I'm not sure :-) The idea here is to not block on the queue,
and instead suspend the request until a runtime is available. Hence the
condition is correct (if !async). What puzzle me is where the
AsyncFilter.unpark() is called....looks like it got deleted. Looking at
it :-)

A+

-- Jeanfrancois



>>
>> All the change is in
>> module/jruby/src/main/java/com/sun/grizzly/jruby/RubyObjectPool.java.
>>
>> The svn diff is provided below :
>>
>> Thanks
>> Pramod Gopinath
>>
>
> ------------------------------------------------------------------------
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_grizzly.dev.java.net
> For additional commands, e-mail: dev-help_at_grizzly.dev.java.net