dev@grizzly.java.net

Re: refactring SelectionKeyHandler related code

From: Oleksiy Stashok <Oleksiy.Stashok_at_Sun.COM>
Date: Tue, 28 Aug 2007 17:48:49 +0200

Jeanfrancois Arcand wrote:
> your proposal looks good. We just need to make sure any applications
> still works withoit any changes....and from the diff it seems they
> will still works :-)
It should work... but in any case I'm looking forward to rid of this
deprecated stuff :)

Harsha wrote:

> Aha... Alexey. Your proposal looks good to me too. It makes more sense more now.
> SelectionKeyHandler is more close to SelectorHandler than the controller in right abstraction.
> Isn't it?

Right.

Charlie wrote:

> try {
> channel.close();
> } catch (IOException ex){
> }
>
> Should we be logging such an example at a FINE level, for instance?
> I suppose I should go back and look at meeting minutes to see what we
> did decide, and if we have addressed my question ;-)

I'm not sure if it makes sense for this try-catch block, but if we have agreed on this rule - it's ok for me :)

WBR,
Alexey.

>
> Thanks
>
> -- Jeanfrancois
>
> Oleksiy Stashok wrote:
>> Hello.
>>
>> Here is update I propose in order to move SelectionKeyHandler from
>> Controller and associate it with SelectorHandler.
>> For a while old methods are marked deprecated, but once we will have
>> a chance - we need to remove them.
>>
>> If you have any comments - welcome :)
>>
>> WBR,
>> Alexey.
>>
>>
>> ------------------------------------------------------------------------
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_grizzly.dev.java.net
>> For additional commands, e-mail: dev-help_at_grizzly.dev.java.net
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_grizzly.dev.java.net
> For additional commands, e-mail: dev-help_at_grizzly.dev.java.net
>