Hi Wolfram,
On 02/10/09 11:38, Wolfram Rittmeyer wrote:
> Jan Luehe wrote:
>>
>> I also realized that we should probably upgrade the version of the
>> sun-web.xml
>> DTD.
>>
>> Traditionally, we've kept its version in sync with that of web.xml.
>>
>> Therefore, I would suggest that we add support for <valve> to
>> sun-web-app_3_0-0.dtd instead of sun-web-app_2_5-0.dtd.
>>
>> I will see what's involved in making this change and will let you know.
>>
>
> Hi Jan,
>
> any news with regard to the DTD?
>
I've created:
deployment/dtds/src/main/resources/glassfish/lib/dtds/sun-web-app_3_0-0.dtd
which right now is an exact copy of sun-web-app_2_5-0.dtd.
> And while we're at it: Any word about the "writeDescriptor"-method in
> WebBundleRuntimeNode? I think I have everything covered there. But I
> still am curious if this method ever gets called - and if so, under
> what circumstances.
Same here. :)
I've found that this method does not get called when I deploy a WAR that
contains a sun-web.xml,
restart the domain, and undeploy. I'm not sure under what other
circumstances it might get called,
or if it ever gets called. I'm not too familiar with that part of the
code. I would think that it is safe to
commit your changes to this file, even if they may never be triggered.
In the meantime, I'll do some
more digging around.
Thanks,
Jan