Hi Wolfram,
On 02/19/09 12:12 PM, Wolfram Rittmeyer wrote:
> My patch for introducing valves which can be configured to take
> parameters actually /did/ contain a bug.
>
> The bug was in the deloyment/dol part of the code. In ValveNode I
> forgot to add the code which iterates over each Node when writing out
> XML. Thanks to Hong's hints about adding the jvm-option -Dwriteout.xml
> to domains.xml I was able to detect this ommission.
>
> This way I finally also found out when the method writeDescriptor()
> gets called ;-)
>
> Now as I wrote in my answer to the committer mail I am a bit unsure
> about procedures. I've found a guidelines page on the wiki which among
> other things says that commits have to be reviewed - thus I've
> attached a diff to this mail. The review should be pretty
> straightforward given the extreme smallness of this patch. If I have
> to consider anything else, please let me know.
Thanks for the patch, and thanks to Hong for the "writeout.xml" system
property hint!
I've reviewed your diffs, and the look good to me.
You have already been granted commit privileges, so go ahead and commit! :)
Please follow this format in your commit message:
Fix for
https://glassfish.dev.java.net/issues/show_bug.cgi?id=<id>
("<synopsis>")
Reviewed by: <reviewer_id>
Tests run: <any tests you have run, at a minimum QL>
Once you've committed, update
https://glassfish.dev.java.net/issues/show_bug.cgi?id=<id>
with the output of the commit command (which includes the new revision
numbers of any
affected files).
Let us know if you have any questions!
Thanks,
Jan
>
> Thanks,
>
> --
> Wolfram Rittmeyer
> ------------------------------------------------------------------------
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: webtier-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: webtier-help_at_glassfish.dev.java.net