Hi Wolfram,
On 01/26/09 23:02, Wolfram Rittmeyer wrote:
> Jan Luehe wrote:
>> Hi Wolfram,
>>
> (...)
>>
>> I think we should retire the PWC error numbers over time, and
>> definitely not add any new ones.
>>
> So I will not add any numbers to my messages.
Correct.
>
>> I'm glad to see that you are making progress!
>
> I think I am nearly done. Of course it needs some testing before
> submitting a patch ;-)
Sounds great!
>
> Roughly speaking I have created a descriptor and a node (deployment)
> and added methods to add Valves to SunWebApp to reflect the changes in
> the sun-web.xml file. Then I used these information in WebModule to
> actually add the Valves specified in the deployment descriptor. Some
> minor changes in other files (e.g. the dtd) were also necessary of
> course.
Yes, the approach you have taken looks very promising!
>
> I did not write any AMX-related classes. I guess they are not
> necessary for this kind of task. Is this correct?
Yes, that's correct.
>
> Another question:
> There is a method writeDescriptor(...) in WebBundleRuntimeNode. I
> added my changes there as well. But when is this method called?
I don't know off the top of my head. This seems to be related to
deployment. Will check,
but if Hong or Tim already know the answer, that would be even better.
Hong and Tim, Wolfram is adding support for <valve> elements and nested
<property> elements
to sun-web.xml, see
https://glassfish.dev.java.net/issues/show_bug.cgi?id=4006 for details.
This RFE actually talks about the enhancements to domain.xml, but
Wolfram agreed to first make
corresponding changes to sun-web.xml.
Thanks!
Jan
>
> --
> Wolfram Rittmeyer
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: webtier-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: webtier-help_at_glassfish.dev.java.net
>