quality@glassfish.java.net

Re: QL fails in check-logged-messages

From: Tom Mueller <tom.mueller_at_oracle.com>
Date: Fri, 25 Jun 2010 09:03:00 -0500

Naman,

This sounds like a very nice tool. I would suggest that if any problem
found by this tool would be considered a P3 or higher defect, then we
should have failure of the tool cause failure of the QL tests.
Otherwise, the failure output will be ignored until much later in the
project when the fix will be more expensive to make.

Tom


On 6/25/2010 12:33 AM, Naman Mehta wrote:
>
> hi all,
>
> I am planning to send same email. How to use this and How to check
> your error?
>
> Right now it's giving error for all messages(from server.log file) not
> specific to your module.
>
> Regards,
> Naman
>
> On Friday 25 June 2010 05:22 AM, Ming Zhang wrote:
>> Naman integrated the check-logged-message target to QL yesterday.
>>
>> Naman, can you add descriptions to section I of
>> quicklook/QuickLook_Test_Instructions.html for how user should
>> use/interpreate this target?
>>
>> Regards,
>> Ming
>>
>> On 6/24/2010 3:32 PM, Jane Young wrote:
>>> Okay, I see the check-logged-message target:
>>>
>>> check-logged-messages:
>>> [echo] Checking messages in:
>>> [echo]
>>> /BUILD_AREA/workspace/gf-trunk-build-continuous/gfv3-gp/glassfishv3/glassfish/domains/domain1/logs/server.log
>>>
>>> [echo] [copy] Copying 1 file to
>>> /export/home1/java_re/BUILD_AREA/workspace/gf-trunk-build-continuous/v3/tests/test-output
>>>
>>> [echo]
>>> [echo] * Message keys logged instead of message:
>>> [echo] (none)
>>> [echo]
>>>
>>> Ming, can you answer Marina's question.
>>>
>>> Thanks,
>>> Jane
>>>
>>>
>>> Marina Vatkina wrote:
>>>> I'm asking what the check-logged-messages test does and how to
>>>> decipher its output?
>>>>
>>>> thanks,
>>>> -marina
>>>>
>>>> Jane Young wrote:
>>>>> I'm not sure what you're asking. But you can check if QL tests
>>>>> are passing on Hudson:
>>>>> http://hudson.glassfish.org/job/gf-trunk-build-continuous/
>>>>> If Hudson tests are passing and your local QL tests are failing
>>>>> then it may be related to your changes.
>>>>>
>>>>> Marina Vatkina wrote:
>>>>>> What does its long output mean and how can I check if I broke
>>>>>> anything?
>>>>>>
>>>>>> thanks,
>>>>>> -marina
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>>
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: quality-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: quality-help_at_glassfish.dev.java.net
>>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>