quality@glassfish.java.net

Re: Important for all: Re: QL fails in check-logged-messages

From: Naman Mehta <Naman.Mehta_at_Sun.COM>
Date: Fri, 25 Jun 2010 11:31:12 +0530

In below email, I mentioned check console output which means check
listed error on QL console only. It doesn't mean to open server.log file
and check.

*Sample output shows as below:*

check-logged-messages:
      [echo] Checking messages in:
      [echo]
/space/gfv3/v3setup/glassfishv3/glassfish/domains/domain1/logs/server.log
      [echo]
      [copy] Copying 1 file to /space/gfv3/test-output
      [echo]
      [echo] * Message keys logged instead of message:
      [echo] (none)
      [echo]
      [echo] * Parameter marker not substituted with value:
      [echo] (none)
      [echo]
      [echo] * Bundle not found:
      [echo] (none)
      [echo]
      [echo] * Messages not found in message bundle:
      [echo] (none)
      [echo]
      [echo] * No message:
      [echo] (none)
      [echo]
      [echo] * Messages with common typo's ('occured' with one 'r',
'dont' missing apostrophe, etc.):
      [echo] (none)
      [echo]
      [echo] * Messages with double apostrophes:
      [echo] (none)
      [echo]
      [echo] * Messages with no proper message Id:
      [echo] /home/naman/jdk1.6.0_12/bin/java
      [echo] start-domain
      [echo]
[#|2010-06-24T14:48:35.326+0530|INFO|glassfish3.1|ShoalLogger|_ThreadID=23;_ThreadName=Thread-1;|GMS
View Change Received for group c1 : Members in view for
MASTER_CHANGE_EVENT(before change analysis) are :
      [echo]
[#|2010-06-24T14:48:35.344+0530|INFO|glassfish3.1|ShoalLogger|_ThreadID=11;_ThreadName=Thread-1;|GMS:Reporting
Joined and Ready state to group c1|#]
      [echo]
[#|2010-06-24T14:48:40.334+0530|INFO|glassfish3.1|ShoalLogger|_ThreadID=23;_ThreadName=Thread-1;|GMS
View Change Received for group c1 : Members in view for
MASTER_CHANGE_EVENT(before change analysis) are :
      [echo]
[#|2010-06-24T14:48:40.336+0530|INFO|glassfish3.1|ShoalLogger|_ThreadID=11;_ThreadName=Thread-1;|Calling
reportMyState() with READY...|#]
      [echo]
[#|2010-06-24T14:48:40.341+0530|INFO|glassfish3.1|ShoalLogger|_ThreadID=23;_ThreadName=Thread-1;|GMS
View Change Received for group c1 : Members in view for
JOINED_AND_READY_EVENT(before change analysis) are :
      [echo]
[#|2010-06-24T14:42:22.438+0530|INFO|glassfish3.1|null|_ThreadID=25;_ThreadName=Thread-1;|SynchronizeFiles:
logger
javax.enterprise.system.tools.admin.com.sun.enterprise.v3.admin.cluster|#]
      [echo]
[#|2010-06-24T15:26:10.736+0530|INFO|glassfish3.1|null|_ThreadID=31;_ThreadName=Thread-1;|SynchronizeFiles:
logger
javax.enterprise.system.tools.admin.com.sun.enterprise.v3.admin.cluster|#]
      [echo]
      [echo]

pass:

fail:
      [echo]
======================================================================
      [echo] FAILED: check-logged-messages
      [echo] Issues found in one or more messages (see results above).
      [echo] Please address them, or if the message should be left as-is,
      [echo] add it to the exclusion list with details why it should be
excluded:
      [echo] /space/gfv3/quicklook/gfproject/log_msg_excl.txt
      [echo]
======================================================================
[INFO] Executed tasks
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESSFUL
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 12 seconds
[INFO] Finished at: Fri Jun 25 11:25:58 IST 2010
[INFO] Final Memory: 13M/143M
[INFO]
------------------------------------------------------------------------


Regards,
Naman


On Friday 25 June 2010 11:20 AM, Naman Mehta wrote:
>
> hi all,
>
> Integrated scripts with QL to verify log messages from server.log file.
>
> This script is checking following errors in server.log file.
>
> * Message keys logged instead of message
> * Parameter marker not substituted with value
> * Bundle not found
> * Messages not found in message bundle
> * No message
> * Messages with common typo's ('occured' with one 'r', 'dont' missing
> apostrophe, etc.)
> * Messages with double apostrophes
> * Messages with no proper message Id
>
> I integrated script in such a way that it wouldn't fail the QL build
> but gives you pass and fail error at the end for log messages.
>
> The script is available under quicklook/gfproject/utils.xml. The same
> folder contains one more file called log_msg_excl.txt which is used by
> utils.xml. This file contains list of messages which needs to be
> excluded during above script run. So messages available part of this
> file doesn't consider to be error message.
>
> When you run the QL at the end it runs target called
> 'check-logged-messages'. It lists the messages from server.log file
> and based on the error it lists on the console.
>
> When you get this kind of error check the console output if you find
> it's from your package/file/module verify those. If you think this
> error is irrelevant or part of LocalStrings.properties file put that
> message or part of the message in log_msg_excl.txt so next time when
> you run it exclude those messages listed under log_msg_excl.txt file.
> We run test multiple times and created log_msg_excl.txt file to put
> all exclude message lists. I also created multiple bugs based on this
> and assigned to different modules.
>
> *What developer needs to do?*
> Make sure to check the pass/fail status. If it shows fails verify
> console output. If it's part of your module fix the same. If you think
> it's need to be part of excluded list then copy under log_msg_excl.txt
> file.
>
> Let me know if you have any question on the same.
>
> Regards,
> Naman
>
> On Friday 25 June 2010 06:39 AM, Ming Zhang wrote:
>> I am done with that.
>> Thanks,
>> Ming
>>
>> On 6/24/2010 5:00 PM, Marina Vatkina wrote:
>>> Ming,
>>>
>>> Can you please move the end result of the tests pass/fail to the
>>> bottom of the output. Otherwise they are lost behind the long list
>>> of messages.
>>>
>>> thanks,
>>> -marina
>>>
>>> Ming Zhang wrote:
>>>> Naman integrated the check-logged-message target to QL yesterday.
>>>>
>>>> Naman, can you add descriptions to section I of
>>>> quicklook/QuickLook_Test_Instructions.html for how user should
>>>> use/interpreate this target?
>>>>
>>>> Regards,
>>>> Ming
>>>>
>>>> On 6/24/2010 3:32 PM, Jane Young wrote:
>>>>> Okay, I see the check-logged-message target:
>>>>>
>>>>> check-logged-messages:
>>>>> [echo] Checking messages in:
>>>>> [echo]
>>>>> /BUILD_AREA/workspace/gf-trunk-build-continuous/gfv3-gp/glassfishv3/glassfish/domains/domain1/logs/server.log
>>>>>
>>>>> [echo] [copy] Copying 1 file to
>>>>> /export/home1/java_re/BUILD_AREA/workspace/gf-trunk-build-continuous/v3/tests/test-output
>>>>>
>>>>> [echo]
>>>>> [echo] * Message keys logged instead of message:
>>>>> [echo] (none)
>>>>> [echo]
>>>>>
>>>>> Ming, can you answer Marina's question.
>>>>>
>>>>> Thanks,
>>>>> Jane
>>>>>
>>>>>
>>>>> Marina Vatkina wrote:
>>>>>> I'm asking what the check-logged-messages test does and how to
>>>>>> decipher its output?
>>>>>>
>>>>>> thanks,
>>>>>> -marina
>>>>>>
>>>>>> Jane Young wrote:
>>>>>>> I'm not sure what you're asking. But you can check if QL tests
>>>>>>> are passing on Hudson:
>>>>>>> http://hudson.glassfish.org/job/gf-trunk-build-continuous/
>>>>>>> If Hudson tests are passing and your local QL tests are failing
>>>>>>> then it may be related to your changes.
>>>>>>>
>>>>>>> Marina Vatkina wrote:
>>>>>>>> What does its long output mean and how can I check if I broke
>>>>>>>> anything?
>>>>>>>>
>>>>>>>> thanks,
>>>>>>>> -marina
>>>>>>>>
>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>>
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>>
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: quality-unsubscribe_at_glassfish.dev.java.net
>>>>> For additional commands, e-mail: quality-help_at_glassfish.dev.java.net
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: quality-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: quality-help_at_glassfish.dev.java.net
>>>
>