Bug Number: 3381
Description: issues identified by findbugs
Obtained from: TopLink team
Submitted by: Chris
Reviewed by: TopLink team
tested with entity-persistence-tests and Oracle-internal tests
No new tests have been added as these changes are mostly making static variables final.
List of changes fixed:
oracle/toplink/essentials/sessions/DatasourceLogin.java:78:78 MS: oracle.toplink.essentials.sessions.DatasourceLogin.encryptedString isn't final but should be (H)
oracle/toplink/essentials/logging/AbstractSessionLog.java:130:130 MS: oracle.toplink.essentials.logging.AbstractSessionLog.CONNECTION_STRING isn't final but should be (H)
oracle/toplink/essentials/logging/AbstractSessionLog.java:135:135 MS: oracle.toplink.essentials.logging.AbstractSessionLog.THREAD_STRING isn't final but should be (H)
oracle/toplink/essentials/mappings/DatabaseMapping.java:81:81 MS: oracle.toplink.essentials.mappings.DatabaseMapping.NO_WEIGHT isn't final but should be (H)
oracle/toplink/essentials/mappings/DatabaseMapping.java:82:82 MS: oracle.toplink.essentials.mappings.DatabaseMapping.WEIGHT_1 isn't final but should be (H)
oracle/toplink/essentials/internal/sessions/AbstractRecord.java:69:69 MS: oracle.toplink.essentials.internal.sessions.AbstractRecord.noEntry isn't final but should be (H)
oracle/toplink/essentials/internal/sessions/DirectCollectionChangeRecord.java:70:70 MS: oracle.toplink.essentials.internal.sessions.DirectCollectionChangeRecord.Null isn't final but should be (H)
oracle/toplink/essentials/internal/helper/Helper.java:63:63 MS: oracle.toplink.essentials.internal.helper.Helper.nullWrapper isn't final but should be (H)
oracle/toplink/essentials/queryframework/DoesExistQuery.java:157:157 RCN: Nullcheck of object at line 159 of value previously dereferenced in oracle.toplink.essentials.queryframework.DoesExistQuery.checkEarlyReturn(Object,java.util.Vector,oracle.toplink.essentials.internal.sessions.AbstractSession,oracle.toplink.essentials.internal.sessions.AbstractRecord) (H)
oracle/toplink/essentials/internal/sessions/IdentityMapAccessor.java:443:443 NP: Null pointer dereference of descriptor in oracle.toplink.essentials.internal.sessions.IdentityMapAccessor.getIdentityMap(oracle.toplink.essentials.descriptors.ClassDescriptor) (H)
oracle/toplink/essentials/internal/weaving/TopLinkMethodWeaver.java:77:77 SA: Self assignment of field oracle.toplink.essentials.internal.weaving.TopLinkMethodWeaver.methodDescriptor in oracle.toplink.essentials.internal.weaving.TopLinkMethodWeaver.TopLinkMethodWeaver(TopLinkClassWeaver,String,String,oracle.toplink.libraries.asm.CodeVisitor) (H)
oracle/toplink/essentials/internal/ejb/cmp3/metadata/listeners/MetadataEntityListener.java:385:385 GC: oracle.toplink.essentials.descriptors.DescriptorEvent is incompatible with expected argument java.lang.Integer in oracle.toplink.essentials.internal.ejb.cmp3.metadata.listeners.MetadataEntityListener.isSessionPostBuildEvent(oracle.toplink.essentials.descriptors.DescriptorEvent) (H)
oracle/toplink/essentials/internal/ejb/cmp3/xml/accessors/XMLClassAccessor.java:501:501 ST: Write to static field oracle.toplink.essentials.internal.ejb.cmp3.xml.accessors.XMLClassAccessor.m_entityMappingsAccess from instance method oracle.toplink.essentials.internal.ejb.cmp3.xml.accessors.XMLClassAccessor.processEntityMappings() (H)
oracle/toplink/essentials/internal/ejb/cmp3/xml/accessors/XMLClassAccessor.java:502:502 ST: Write to static field oracle.toplink.essentials.internal.ejb.cmp3.xml.accessors.XMLClassAccessor.m_entityMappingsSchema from instance method oracle.toplink.essentials.internal.ejb.cmp3.xml.accessors.XMLClassAccessor.processEntityMappings() (H)
oracle/toplink/essentials/internal/ejb/cmp3/xml/accessors/XMLClassAccessor.java:503:503 ST: Write to static field oracle.toplink.essentials.internal.ejb.cmp3.xml.accessors.XMLClassAccessor.m_entityMappingsCatalog from instance method oracle.toplink.essentials.internal.ejb.cmp3.xml.accessors.XMLClassAccessor.processEntityMappings() (H)
oracle/toplink/essentials/internal/ejb/cmp3/xml/accessors/XMLClassAccessor.java:505:505 ST: Write to static field oracle.toplink.essentials.internal.ejb.cmp3.xml.accessors.XMLClassAccessor.m_entityMappingsAccess from instance method oracle.toplink.essentials.internal.ejb.cmp3.xml.accessors.XMLClassAccessor.processEntityMappings() (H)
oracle/toplink/essentials/internal/ejb/cmp3/xml/accessors/XMLClassAccessor.java:506:506 ST: Write to static field oracle.toplink.essentials.internal.ejb.cmp3.xml.accessors.XMLClassAccessor.m_entityMappingsSchema from instance method oracle.toplink.essentials.internal.ejb.cmp3.xml.accessors.XMLClassAccessor.processEntityMappings() (H)
oracle/toplink/essentials/internal/ejb/cmp3/xml/accessors/XMLClassAccessor.java:507:507 ST: Write to static field oracle.toplink.essentials.internal.ejb.cmp3.xml.accessors.XMLClassAccessor.m_entityMappingsCatalog from instance method oracle.toplink.essentials.internal.ejb.cmp3.xml.accessors.XMLClassAccessor.processEntityMappings() (H)
oracle/toplink/essentials/mappings/DatabaseMapping.java:78:78 MS: oracle.toplink.essentials.mappings.DatabaseMapping.NO_FIELDS isn't final but should be (H)
oracle/toplink/essentials/ejb/cmp3/EntityManagerFactoryProvider.java:98:98 MS: oracle.toplink.essentials.ejb.cmp3.EntityManagerFactoryProvider.emSetupImpls isn't final but should be (H)