persistence@glassfish.java.net

Re: JPQL: fix ClassCastException if second MOD argument is a field access expression

From: Tom Ware <tom.ware_at_oracle.com>
Date: Wed, 11 Apr 2007 13:11:49 -0400

Hi Michael,

  Sorry for the delay in my reply.

  The fix and tests look good. Please go ahead and check-in.

-Tom

Michael Bouschen wrote:

> Hi Tom,
>
> attached you find my changes to fix issue 2771 "MOD does not allow
> field expressions on both sides"
> (https://glassfish.dev.java.net/issues/show_bug.cgi?id=2771).
>
> The MOD implementation in ModNode assumed that the second argument of
> a MOD function call is always an integer literal .I changed the
> implementation to be similar to PlusNode, MinusNode, etc. You find the
> fix and new test cases attached. Please have a look.
>
> Thanks!
>
> Regards Michael