Hi, Craig
I like the idea that one toplink jar file including the agent.
However, many documentations is already using the agent. Hmm...
How about toplink-essentials.jar including the agent class and manifest
entry without removing toplink-essentials-agent.jar if there is not an
issue? Then, we encourage people to use toplink-essentials.jar instead of
old agent jar. It will maintain backward compatibility.
Cheers,
-Wonseok
On 2/13/07, Craig L Russell <Craig.Russell_at_sun.com> wrote:
>
> Just one more comment.
>
> I don't understand why we need two different jar files for the
> implementation and the agent. The services technology is used to find
> the agent. There's no reason that I know of to *not* package the
> agent with the implementation jar. One less thing for the user to
> worry about.
>
> Craig
>
> On Feb 12, 2007, at 8:05 AM, Craig L Russell wrote:
>
> > Hi Marina,
> >
> > Just a few comments.
> >
> > 1. There are two groups of code here: the standard and the toplink
> > implementation. It would be better if we grouped them as such:
> >
> > groupId javax.persistence: contains persistence-apiXXX.jar as in
> > your proposal
> > groupId toplink.essentials: should contain toplink-
> > essentialsXXX.jar and toplink-essentials-agentXXX.jar
> >
> > 2. I like the toplink version notation including the build number.
> >
> > 3. It is a shame the original persistence-api jar was published
> > with a version number of 1.0 when it was not final. I don't have a
> > good alternative to 1.0b even though I hate it.
> >
> > Craig
> >
> > On Feb 8, 2007, at 6:52 PM, Marina Vatkina wrote:
> >
> >> I made the following changes to create jars with a new version:
> >>
> >> 1. Changed version of the persistence-api related files to 1.0b in
> >> persistence-api:
> >> Index: build.properties
> >> ===================================================================
> >> RCS file: /cvs/glassfish/persistence-api/build.properties,v
> >> retrieving revision 1.4
> >> diff -r1.4 build.properties
> >> 29c29
> >> < release.version=1.0
> >> ---
> >> > release.version=1.0b
> >>
> >> 2. Changed version of the toplink related files to 2.0-35 and the
> >> dependency on the p-api to 1.0b in entity-persistence:
> >>
> >> Index: build.properties
> >> ===================================================================
> >> RCS file: /cvs/glassfish/entity-persistence/build.properties,v
> >> retrieving revision 1.2
> >> diff -r1.2 build.properties
> >> 29c29
> >> < release.version=1.0
> >> ---
> >> > release.version=2.0-35
> >> Index: toplink-essentials.pom
> >> ===================================================================
> >> RCS file: /cvs/glassfish/entity-persistence/toplink-essentials.pom,v
> >> retrieving revision 1.1
> >> diff -r1.1 toplink-essentials.pom
> >> 10c10
> >> < <version>1.0</version>
> >> ---
> >> > <version>1.0b</version>
> >>
> >> I tested by creating the files without pushing them to the
> >> repository. Their names look correct:
> >>
> >> persistence-api/build/maven-repo/javax.persistence/jars/
> >> persistence-api-1.0b.jar
> >> persistence-api/build/maven-repo/javax.persistence/jars/
> >> persistence-api-1.0b.jar.md5
> >> persistence-api/build/maven-repo/javax.persistence/poms/
> >> persistence-api-1.0b.pom
> >> persistence-api/build/maven-repo/javax.persistence/poms/
> >> persistence-api-1.0b.pom.md5
> >> persistence-api/build/maven-repo/javax.persistence/java-sources/
> >> persistence-api-1.0b-sources.jar
> >> persistence-api/build/maven-repo/javax.persistence/java-sources/
> >> persistence-api-1.0b-sources.jar.md5
> >>
> >> entity-persistence/build/maven-repo/javax.persistence/jars/toplink-
> >> essentials-2.0-35.jar
> >> entity-persistence/build/maven-repo/javax.persistence/jars/toplink-
> >> essentials-2.0-35.jar.md5
> >> entity-persistence/build/maven-repo/javax.persistence/poms/toplink-
> >> essentials-2.0-35.pom
> >> entity-persistence/build/maven-repo/javax.persistence/poms/toplink-
> >> essentials-2.0-35.pom.md5
> >> entity-persistence/build/maven-repo/javax.persistence/java-sources/
> >> toplink-essentials-2.0-35-sources.jar
> >> entity-persistence/build/maven-repo/javax.persistence/java-sources/
> >> toplink-essentials-2.0-35-sources.jar.md5
> >> entity-persistence/build/maven-repo/
> >> oracle.toplink.essentials.agent/jars/toplink-essentials-
> >> agent-2.0-35.jar
> >> entity-persistence/build/maven-repo/
> >> oracle.toplink.essentials.agent/jars/toplink-essentials-
> >> agent-2.0-35.jar.md5
> >> entity-persistence/build/maven-repo/
> >> oracle.toplink.essentials.agent/poms/toplink-essentials-
> >> agent-2.0-35.pom
> >> entity-persistence/build/maven-repo/
> >> oracle.toplink.essentials.agent/poms/toplink-essentials-
> >> agent-2.0-35.pom.md5
> >> entity-persistence/build/maven-repo/
> >> oracle.toplink.essentials.agent/java-sources/toplink-essentials-
> >> agent-2.0-35-sources.jar
> >> entity-persistence/build/maven-repo/
> >> oracle.toplink.essentials.agent/java-sources/toplink-essentials-
> >> agent-2.0-35-sources.jar.md5
> >>
> >>
> >> thanks,
> >> -marina
> >> <mavenized-changes.jar>
> >
> > Craig Russell
> > Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
> > 408 276-5638 mailto:Craig.Russell_at_sun.com
> > P.S. A good JDO? O, Gasp!
> >
>
> Craig Russell
> Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
> 408 276-5638 mailto:Craig.Russell_at_sun.com
> P.S. A good JDO? O, Gasp!
>
>
>