Hi Tom, hi Jielin,
attached you find my changes to fix issue 1256 "Cleanup internal
EJBQLParser API":
https://glassfish.dev.java.net/issues/show_bug.cgi?id=1256.
This change cleans up the the API of the parser class EJBQLParser which
is the superclass of the ANTLR generated parser class. I collapsed the
two classes EJBQLParserBase and EJBQLParser by merging the superclass
EJBQLParserBase into EJBQLParser. I also introduced a single method
parse that starts the parsing process and added some javadoc.
Jielin,
A heads up: I expect you need to change method handleANTLRException as
part of fixing issue 1355 (adding line and column info to error
messages). Please note, that my change will move this method from
EJBQLParserBase to EJBQLParser.
Thanks!
Regards Michael