persistence@glassfish.java.net

Re: Code review request for Issue #150

From: Sanjeeb Kumar Sahoo <Sanjeeb.Sahoo_at_Sun.COM>
Date: Wed, 18 Jan 2006 07:42:08 +0530

Hi Tom,

Since in a separate email conversation we understood that my suggested
fix would not make matter worse and it addresses a NPE that our verifier
is getting I am checking in this fix in the trunk. As you mentioned in
that email, we may have to rework to fix issue #117.

Thanks,
Sahoo

Tom Ware wrote:

> I am trying to get fixes in today.
>
> -Tom
>
> Sanjeeb Kumar Sahoo wrote:
>
>> Tom Ware wrote:
>>
>>
>>
>>> Hi Sahoo,
>>>
>>> I believe the change you have proposed potentially reopens issue 117
>>> since an exception can occur after the session is added to the
>>> SessionManager. I have a fix for issue 150 in my local workspace.
>>> How urgent is it that this gets fixed?
>>>
>>
>>
>> Very urgent.
>>
>> Thanks,
>> Sahoo
>>
>>
>>
>>> -Tom
>>>
>>> Sanjeeb Kumar Sahoo wrote:
>>>
>>>
>>>
>>>> (Resending with a different attachment as Marina pointed out some
>>>> mail server rejects .zip attachment)
>>>>
>>>> Hi Tom,
>>>>
>>>> Attached here with is the change needed to fix issue
>>>> https://glassfish.dev.java.net/issues/show_bug.cgi?id=150. It contains
>>>> both the new, old files and the diff. Please review them. Please
>>>> open it as a zip file.
>>>>
>>>> Thanks,
>>>> Sahoo
>>>>
>>>>
>>>>
>>>>
>>>
>