persistence@glassfish.java.net

Re: [Code Review]Updating GlassFish to use PFD version of persistence spi

From: Tom Ware <tom.ware_at_oracle.com>
Date: Tue, 31 Jan 2006 16:18:17 -0500

Hi,

  The tests we are talking about are not TCK tests. They are unit tests
for features that have been added to the core of the entity-persistence
module. As a result, I think excluding them from platforms that do not
support the functionality is an option.

  EJBQL will always generate a combination of LTRIM and RTRIM for this
very reason and therefore should work on Derby.

  If we want increased functionality on Derby it might be a good idea to
make DerbyPlatform support what Craig suggests below. It should be a
fairly simple task.

-Tom

Craig L Russell wrote:

>Hi,
>
>On Jan 31, 2006, at 9:50 AM, Mitesh Meswani wrote:
>
>
>
>>Sahoo,
>>
>>
>>
>>>Internal Exception: org.apache.derby.client.am.SqlException:
>>>'TRIM' is not recognized as a function or procedure.Error Code: -1
>>>Call:SELECT ID, ITEM_VERSION, DESCRIPTION, NAME FROM CMP3_ITEM
>>>WHERE (TRIM(NAME) = 'tem')
>>>
>>>
>>Trim is not supported on Derby. This is a known issue. I think we
>>will need to find out a mechanism to exclude such tests on Derby.
>>
>>
>
>There is nothing in the spec about support for TRIM being optional,
>except for the specification of a trim character other than blank. So
>excluding the test is not an option.
>
>Apparently Derby supports LTRIM and RTRIM, so the generated SQL might
>include LTRIM(RTRIM(NAME)) = 'tem'.
>
>Craig
>
>Craig Russell
>Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
>408 276-5638 mailto:Craig.Russell_at_sun.com
>P.S. A good JDO? O, Gasp!
>
>
>

-- 
Tom Ware
Principal Software Engineer
Oracle Canada Inc.
Direct: (613) 783-4598
Email: tom.ware_at_oracle.com