Hi Mitesh,
Mitesh Meswani wrote:
> Hi Sahoo,
>
> InstrumentableClassLoader.java:
> Please change the javadoc as follows
> /**
> * Registers the supplied transformer. All future class definitions
> * loaded by this loader will be first passed to the transformer.
> *
> * @param transformer The transformer to register with the loader
> * *_at_see
> java.lang.instrument.Instrumentation#addTransformer(ClassFileTransformer)*
Why do I need to specify the argument? It is not an overloaded method.
Thanks,
Sahoo
> */
> public void addTransformer(ClassFileTransformer transformer);
>
> The changes look good to me otherwise.
>
> -Mitesh
>
> Sanjeeb Kumar Sahoo wrote:
>
>> Hi Tom,
>>
>> Attached here with are the changes. I have done a clean build. Please
>> review the following changes include:
>>
>> persistence-api/src/java/javax/persistence/spi/PersistenceUnitInfo.java:
>> It now uses ClassTransformer.
>> getTempClassLoader is renamed as getNewTempClassLoader.
>> related javadoc updates. It has ripple effect on entity-persistence
>> module. So I changed them as well.
>>
>> entity-persistence/src/java/oracle/toplink/essentials/ejb/cmp3/EntityManagerFactoryProvider.java
>>
>> entity-persistence/src/java/oracle/toplink/essentials/ejb/cmp3/persistence/PersistenceUnitInfo.java
>>
>> entity-persistence/src/java/oracle/toplink/essentials/internal/ejb/cmp3/EntityManagerSetupImpl.java
>>
>> entity-persistence/src/java/oracle/toplink/essentials/internal/ejb/cmp3/JavaSECMPInitializer.java
>>
>> entity-persistence/src/java/oracle/toplink/essentials/internal/weaving/TopLinkWeaver.java
>>
>> entity-persistence/src/java/oracle/toplink/essentials/internal/weaving/TransformerFactory.java
>>
>>
>> Mitesh,
>>
>> would you mind reviewing the following changes:
>>
>> appserv-core/src/java/com/sun/enterprise/loader/EJBClassLoader.java
>> appserv-core/src/java/com/sun/enterprise/loader/InstrumentableClassLoader.java
>>
>> appserv-core/src/java/com/sun/enterprise/server/PersistenceUnitInfoImpl.java
>>
>> appserv-core/src/java/com/sun/enterprise/web/WebModuleListener.java
>>
>> To avoid conflicts, I would like to check them in ASAP, preferrably
>> tonight (my time). So I will appreciate a faster turn around.
>>
>> Thanks,
>> Sahoo
>