Go ahead. I have just run some equivalent internal tests against your
changes with no issues.
-Tom
Sanjeeb Kumar Sahoo wrote:
>Tom,
>
>can I check my changes in? Do you think my changes can cause those failures?
>
>Mitesh,
>thanks for your response.
>
>Comments in line...
>
>Mitesh Meswani wrote:
>
>
>
>>Sahoo,
>>
>>Please see inline....
>>
>>Sanjeeb Kumar Sahoo wrote:
>>
>>
>>
>>>Hi Tom,
>>>
>>>I am running tests against Derby. I got the following result:
>>> [junit] Running
>>>oracle.toplink.essentials.testing.tests.FullRegressionTestSuite
>>> [junit] Tests run: 82, Failures: 0, Errors: 8, Time elapsed:
>>>60.336 sec
>>> [junit] Test
>>>oracle.toplink.essentials.testing.tests.FullRegressionTestSuite FAILED
>>>
>>>Tests fail for following reasons:
>>>Internal Exception: org.apache.derby.client.am.SqlException: Columns
>>>of type 'DATE' cannot hold values of type 'TIMESTAMP'. Error Code: -1
>>>Call:INSERT INTO CMP3_EMPLOYEE (EMP_ID, F_NAME, L_NAME, VERSION,
>>>START_DATE, END_DATE, ADDR_ID, manager_EMP_ID) VALUES (102, 'Jill',
>>>'May', 1,
>>>{ts '1895-01-01 00:00:00.0'}, NULL, 10, NULL)
>>>
>>>
>>This might be a newly added test / regression due to issue 190
>><https://glassfish.dev.java.net/issues/show_bug.cgi?id=190>
>>
>>
>>
>>>*OR*
>>>
>>>Internal Exception: org.apache.derby.client.am.SqlException: 'TRIM'
>>>is not recognized as a function or procedure.Error Code: -1
>>>Call:SELECT ID, ITEM_VERSION, DESCRIPTION, NAME FROM CMP3_ITEM WHERE
>>>(TRIM(NAME) = 'tem')
>>>
>>>
>>Trim is not supported on Derby. This is a known issue.
>>
>>
>
>If it is a known failure, then I expect the readme in tests directory to
>have such information.
>
>
>
>>I think we will need to find out a mechanism to exclude such tests on
>>Derby.
>>
>>Meanwhile, could you run the tests against oracle...here is an oracle
>>instance you can run against.
>>
>>
>
>You want me to run tests against your Oracle db hosted in US from India
>and that too I am working from home now. I would prefer not to. I
>don't think my changes have anything to do with these failures.
>
>Thanks,
>Sahoo
>
>
>
>>jdbc.driver.jar= /home/mm110999/cmp/oracledrivers/ojdbc14.jar
>>db.driver=oracle.jdbc.driver.OracleDriver
>>db.url=jdbc:oracle:thin:@liua.red.iplanet.com:1521:TP
>>db.user=mitesh
>>db.pwd=mitesh
>>tl.platform=oracle.toplink.essentials.platform.database.oracle.OraclePlatform
>>
>>
>>Thanks,
>>Mitesh
>>
>>
>>
>>>My build.properties look as follows:
>>>jdbc.driver.jar=/home/ss141213/ROOT/WS/gf/publish/glassfish/derby/lib/derbyclient.jar
>>>
>>>db.driver=org.apache.derby.jdbc.ClientDriver
>>>db.url=jdbc:derby://localhost:1527/sun-appserv-samples
>>>db.user=APP
>>>db.pwd=APP
>>>tl.platform=oracle.toplink.essentials.platform.database.DerbyPlatform
>>>
>>>db.type=true
>>>result.file=testresults
>>>junit.location=/home/ss141213/ROOT/WS/20051028/glassfish/appserv-tests/lib/junit.jar
>>>
>>>
>>>## component defined properties.
>>>src.dir=src/java
>>>component.classes.dir=build
>>>maven.netbeans.exec.build=build
>>>
>>>Am I doing anything wrong here?
>>>
>>>Thanks,
>>>Sahoo
>>>
>>>Tom Ware wrote:
>>>
>>>
>>>
>>>>Hi Sahoo,
>>>>
>>>> That changes look good.
>>>>
>>>> Please ensure the entity-persistence tests pass before checking in.
>>>>
>>>>Thanks,
>>>>Tom
>>>>
>>>>Sanjeeb Kumar Sahoo wrote:
>>>>
>>>>
>>>>
>>>>>Hi Tom,
>>>>>
>>>>>Attached here with are the changes. I have done a clean build.
>>>>>Please review the following changes include:
>>>>>
>>>>>persistence-api/src/java/javax/persistence/spi/PersistenceUnitInfo.java:
>>>>>
>>>>>It now uses ClassTransformer.
>>>>>getTempClassLoader is renamed as getNewTempClassLoader.
>>>>>related javadoc updates. It has ripple effect on entity-persistence
>>>>>module. So I changed them as well.
>>>>>
>>>>>entity-persistence/src/java/oracle/toplink/essentials/ejb/cmp3/EntityManagerFactoryProvider.java
>>>>>
>>>>>entity-persistence/src/java/oracle/toplink/essentials/ejb/cmp3/persistence/PersistenceUnitInfo.java
>>>>>
>>>>>entity-persistence/src/java/oracle/toplink/essentials/internal/ejb/cmp3/EntityManagerSetupImpl.java
>>>>>
>>>>>entity-persistence/src/java/oracle/toplink/essentials/internal/ejb/cmp3/JavaSECMPInitializer.java
>>>>>
>>>>>entity-persistence/src/java/oracle/toplink/essentials/internal/weaving/TopLinkWeaver.java
>>>>>
>>>>>entity-persistence/src/java/oracle/toplink/essentials/internal/weaving/TransformerFactory.java
>>>>>
>>>>>
>>>>>Mitesh,
>>>>>
>>>>>would you mind reviewing the following changes:
>>>>>
>>>>>appserv-core/src/java/com/sun/enterprise/loader/EJBClassLoader.java
>>>>>appserv-core/src/java/com/sun/enterprise/loader/InstrumentableClassLoader.java
>>>>>
>>>>>appserv-core/src/java/com/sun/enterprise/server/PersistenceUnitInfoImpl.java
>>>>>
>>>>>appserv-core/src/java/com/sun/enterprise/web/WebModuleListener.java
>>>>>
>>>>>To avoid conflicts, I would like to check them in ASAP, preferrably
>>>>>tonight (my time). So I will appreciate a faster turn around.
>>>>>
>>>>>Thanks,
>>>>>Sahoo
>>>>>
>>>>>
>>>>>
>>>>>
>
>
>
--
Tom Ware
Principal Software Engineer
Oracle Canada Inc.
Direct: (613) 783-4598
Email: tom.ware_at_oracle.com