persistence@glassfish.java.net

Re: [Code Review]Updating GlassFish to use PFD version of persistence spi

From: Tom Ware <tom.ware_at_oracle.com>
Date: Tue, 31 Jan 2006 10:57:22 -0500

Hi Sahoo,

  That changes look good.

  Please ensure the entity-persistence tests pass before checking in.

Thanks,
Tom

Sanjeeb Kumar Sahoo wrote:

>Hi Tom,
>
>Attached here with are the changes. I have done a clean build. Please
>review the following changes include:
>
>persistence-api/src/java/javax/persistence/spi/PersistenceUnitInfo.java:
>It now uses ClassTransformer.
>getTempClassLoader is renamed as getNewTempClassLoader.
>related javadoc updates. It has ripple effect on entity-persistence
>module. So I changed them as well.
>
>entity-persistence/src/java/oracle/toplink/essentials/ejb/cmp3/EntityManagerFactoryProvider.java
>entity-persistence/src/java/oracle/toplink/essentials/ejb/cmp3/persistence/PersistenceUnitInfo.java
>entity-persistence/src/java/oracle/toplink/essentials/internal/ejb/cmp3/EntityManagerSetupImpl.java
>entity-persistence/src/java/oracle/toplink/essentials/internal/ejb/cmp3/JavaSECMPInitializer.java
>entity-persistence/src/java/oracle/toplink/essentials/internal/weaving/TopLinkWeaver.java
>entity-persistence/src/java/oracle/toplink/essentials/internal/weaving/TransformerFactory.java
>
>Mitesh,
>
>would you mind reviewing the following changes:
>
>appserv-core/src/java/com/sun/enterprise/loader/EJBClassLoader.java
>appserv-core/src/java/com/sun/enterprise/loader/InstrumentableClassLoader.java
>appserv-core/src/java/com/sun/enterprise/server/PersistenceUnitInfoImpl.java
>appserv-core/src/java/com/sun/enterprise/web/WebModuleListener.java
>
>To avoid conflicts, I would like to check them in ASAP, preferrably
>tonight (my time). So I will appreciate a faster turn around.
>
>Thanks,
>Sahoo
>
>

-- 
Tom Ware
Principal Software Engineer
Oracle Canada Inc.
Direct: (613) 783-4598
Email: tom.ware_at_oracle.com