>From 12c8085638df58e6a5ee2fa484dd0d180528abe8 Mon Sep 17 00:00:00 2001 From: Arkadiusz Orzechowski Date: Tue, 5 Mar 2013 20:28:12 +0100 Subject: [PATCH] GLASSFISH-19476 fix resources leak in pool resizer Resources leak in pool resizer when preferValidateOverRecreate is set to true for the pool. In Resizer.removeIdleAndInvalidResources method, resource not eligible for removal was neither removed nor marked active(to be closed later in the finally block). --- .../main/java/com/sun/enterprise/resource/pool/resizer/Resizer.java | 1 + 1 file changed, 1 insertion(+) diff --git a/appserver/connectors/connectors-runtime/src/main/java/com/sun/enterprise/resource/pool/resizer/Resizer.java b/appserver/connectors/connectors-runtime/src/main/java/com/sun/enterprise/resource/pool/resizer/Resizer.java index 9b3841d..f41427e 100644 --- a/appserver/connectors/connectors-runtime/src/main/java/com/sun/enterprise/resource/pool/resizer/Resizer.java +++ b/appserver/connectors/connectors-runtime/src/main/java/com/sun/enterprise/resource/pool/resizer/Resizer.java @@ -200,6 +200,7 @@ protected int removeIdleAndInvalidResources() { //preferValidateOverrecreate true and connection is valid within SPS validConnectionsCounter++; idleConnKeptInSteadyCounter++; + activeResources.add(h); debug("PreferValidateOverRecreate: Keeping idle resource " + h + " in the steady part of the free pool " + "as the RA reports it to be valid (" + validConnectionsCounter -- 1.7.10