Received: from datsunx.SFBay.Sun.COM (datsunx [129.145.132.37])
	by datsun.SFBay.Sun.COM (8.14.2+Sun/8.14.2) with ESMTP id n8BNZRbQ003237
	for <shannon-record@datsun.SFBay.Sun.COM>; Fri, 11 Sep 2009 16:35:27 -0700 (PDT)
Received: from [127.0.0.1] (datsunx.local [127.0.0.1])
	by datsunx.SFBay.Sun.COM (8.14.3+Sun/8.14.3) with ESMTP id n8BNcJ7F015965;
	Fri, 11 Sep 2009 16:38:20 -0700 (PDT)
Message-ID: <4AAADF6B.2040603@sun.com>
Date: Fri, 11 Sep 2009 16:38:19 -0700
From: Bill Shannon <bill.shannon@sun.com>
User-Agent: Thunderbird 2.0.0.21 (X11/20090323)
MIME-Version: 1.0
To: dev@glassfish.dev.java.net
CC: Jagadesh B Munta <Jagadesh.Munta@sun.com>
Subject: FindBugs support
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

I've just committed some changes to support running FindBugs for GlassFish.
At the top level, or in any module, you can run

mvn findbugs:findbugs

to generate the FindBugs XML report, which is not very readable directly
but is used by the Hudson FindBugs plugin to generate a more readable
report.  Hopefully Jane will be setting up Hudson to do that soon.

You can also run

mvn site

to generate a more readable html report that you can browse.  Open the
target/site/findbugs.html file to browse the report.

I hope this will encourage everyone to run FindBugs before committing
changes, and to continue to clean up the existing FindBugs errors.

The current scheme uses an exclude file per module to exclude a very small
number of errors reported by FindBugs.  Do not modify these exclude files
yourself.  Instead, send mail to Jagadesh and me with the details of why
you think your FindBugs error should be excluded.  Expect the answer to
be "no".  :-)

Thanks.