Hi Reza,
No problem at all. I hope my patches are useful :)
Dave.
> On 23 Feb 2015, at 19:20, Reza Rahman <Reza.Rahman_at_oracle.com> wrote:
>
> Thanks very much. I am sure one of our developers will take a look at it as soon as they can!
>
>> On Feb 23, 2015, at 2:00 PM, David Salter <davidmsalter_at_icloud.com> wrote:
>>
>> Hi,
>>
>> I’ve just fixed issue GLASSFISH-13958 and added a patch into Jira. I’ve attached the patch here as well if anyone wants to look at it.
>>
>> The issue relates to setting the database vendor when creating a JDBC connection pool. The Jira issue says it affects version 3.1 of GlassFish, but its still present in 4.1
>>
>> Hope this is OK.
>>
>> Thanks,
>>
>> Dave.
>>
>>
>> Index: appserver/admingui/jdbc/src/main/resources/jdbcConnectionPoolNew1.jsf
>> ===================================================================
>> --- appserver/admingui/jdbc/src/main/resources/jdbcConnectionPoolNew1.jsf (revision 63779)
>> +++ appserver/admingui/jdbc/src/main/resources/jdbcConnectionPoolNew1.jsf (working copy)
>> @@ -2,7 +2,7 @@
>>
>> DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
>>
>> - Copyright (c) 1997-2013 Oracle and/or its affiliates. All rights reserved.
>> + Copyright (c) 1997-2015 Oracle and/or its affiliates. All rights reserved.
>>
>> The contents of this file are subject to the terms of either the GNU
>> General Public License Version 2 only ("GPL") or the Common Development
>> @@ -110,7 +110,7 @@
>> />
>> </sun:dropDown>
>> "<br/>
>> - <sun:textField id="dbField" columns="$int{60}" maxLength="#{sessionScope.fieldLengths['maxLength.common.resType']}" text="#{wizardPoolExtra.DBVendorField}" onFocus="emptyDropdown(this.value);">
>> + <sun:textField id="dbField" columns="$int{60}" maxLength="#{sessionScope.fieldLengths['maxLength.common.resType']}" text="#{wizardPoolExtra.DBVendorField}" onChange="emptyDropdown(this.value);" onKeyUp="emptyDropdown(this.value);">
>> <!afterCreate
>> getClientId(component="$this{component}" clientId="#{pageSession.dbFieldId}");
>> />
>> @@ -139,7 +139,9 @@
>> }
>>
>> function emptyDropdown(fieldValue) {
>> - getSelectElement('#{pageSession.dbBoxId}').value="";
>> + if (getTextElement('#{pageSession.dbFieldId}').value != '') {
>> + getSelectElement('#{pageSession.dbBoxId}').value="";
>> + }
>> }
>> </script>
>> </f:verbatim>