That will be fine. Thanks for your contribution.
Anissa
On 2/12/15 9:14 AM, David Salter wrote:
> Hi Anissa,
>
> I just have observer role and not developer for GlassFish.
>
> I’ve added a comment on the issue containing the patch as I couldn’t see a way to make attachments.
>
> Hope that’s OK.
>
> Thanks,
>
> Dave.
>
>> On 12 Feb 2015, at 16:39, Anissa Lam<anissa.lam_at_oracle.com> wrote:
>>
>> Hi David,
>>
>> Thanks for the effort. I suppose you don't have the developer role for glassfish.
>> Please attach the patch to the bug report, and when we are ready for the next release, and this bug is a candidate for fixing, we will include the fix and test that out.
>>
>> thanks
>> Anissa.
>>
>> On 2/12/15 5:53 AM, David Salter wrote:
>>> Hi,
>>>
>>> I’ve created a patch for an issue in GlassFish - GLASSFISH-21179
>>>
>>> This is my first patch for GlassFish (you’ve got to start somewhere!). What’s the best procedure for submitting this? Is it to mail this list, or add it as an attachment into Jira?
>>>
>>> I’ve attached the patch below if someone could take a look and check it’s OK.
>>>
>>> Thanks,
>>>
>>> Dave.
>>>
>>>
>>> Index: appserver/admingui/common/src/main/resources/appServer/domainTabs.inc
>>> ===================================================================
>>> --- appserver/admingui/common/src/main/resources/appServer/domainTabs.inc (revision 63769)
>>> +++ appserver/admingui/common/src/main/resources/appServer/domainTabs.inc (working copy)
>>> @@ -2,7 +2,7 @@
>>>
>>> DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
>>>
>>> - Copyright (c) 2010-2012 Oracle and/or its affiliates. All rights reserved.
>>> + Copyright (c) 2010-2015 Oracle and/or its affiliates. All rights reserved.
>>>
>>> The contents of this file are subject to the terms of either the GNU
>>> General Public License Version 2 only ("GPL") or the Common Development
>>> @@ -43,7 +43,7 @@
>>> <!-- appServer/domainTabs.jsf -->
>>>
>>> <sun:tabSet id="domainTabs" immediate="true" selected="#{sessionScope.domainTabs}">
>>> -<sun:tab id="domainAttrs" immediate="true" text="$resource{i18n.headings.DomainAttributesTab}" toolTip="$resource{i18n.headings.DomainAttributesTab}">
>>> +<sun:tab id="domainAttrs" immediate="true" text="$resource{i18n.headings.DomainAttributes}" toolTip="$resource{i18n.headings.DomainAttributesTab}">
>>> <!command
>>> setSessionAttribute(key="domainTabs" value="domainAttrs");
>>> gf.redirect(page="#{request.contextPath}/common/appServer/serverInstDomainAttrs.jsf");