dev@glassfish.java.net

pom.xml review - add missing dependencies for FindBugs

From: Bill Shannon <bill.shannon_at_oracle.com>
Date: Mon, 23 Sep 2013 17:14:48 -0700

The following changes get rid of most of the "missing classes"
messages when running FindBugs. I'm not sure they're all the
"best" dependencies, or that they've been added in the "best"
places, so please review.

Thanks.

Index: appserver/web/web-core/pom.xml
===================================================================
--- appserver/web/web-core/pom.xml (revision 62735)
+++ appserver/web/web-core/pom.xml (working copy)
@@ -132,5 +132,10 @@
             <artifactId>logging-annotation-processor</artifactId>
             <optional>true</optional>
         </dependency>
+ <dependency> <!-- for FindBugs -->
+ <groupId>org.osgi</groupId>
+ <artifactId>org.osgi.core</artifactId>
+ <scope>provided</scope>
+ </dependency>
    </dependencies>
 </project>
Index: appserver/jms/admin/pom.xml
===================================================================
--- appserver/jms/admin/pom.xml (revision 62735)
+++ appserver/jms/admin/pom.xml (working copy)
@@ -163,6 +163,12 @@
             <artifactId>logging-annotation-processor</artifactId>
             <optional>true</optional>
         </dependency>
+ <dependency> <!-- for FindBugs -->
+ <groupId>org.glassfish.main.core</groupId>
+ <artifactId>kernel</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
+ </dependency>
     </dependencies>
 </project>

Index: appserver/admingui/core/pom.xml
===================================================================
--- appserver/admingui/core/pom.xml (revision 62735)
+++ appserver/admingui/core/pom.xml (working copy)
@@ -221,6 +221,22 @@
             <version>${project.version}</version>
             <scope>provided</scope>
         </dependency>
+ <dependency> <!-- for FindBugs -->
+ <groupId>javax.ws.rs</groupId>
+ <artifactId>javax.ws.rs-api</artifactId>
+ <scope>provided</scope>
+ </dependency>
+ <dependency> <!-- for FindBugs -->
+ <groupId>org.glassfish.jersey.media</groupId>
+ <artifactId>jersey-media-json-jackson</artifactId>
+ <scope>provided</scope>
+ </dependency>
+ <dependency> <!-- for FindBugs -->
+ <groupId>com.sun.pkg</groupId>
+ <artifactId>pkg-java</artifactId>
+ <version>1.0.0-alpha-1</version>
+ <scope>provided</scope>
+ </dependency>


     </dependencies>
Index: appserver/resources/javamail/javamail-runtime/pom.xml
===================================================================
--- appserver/resources/javamail/javamail-runtime/pom.xml (revision 62735)
+++ appserver/resources/javamail/javamail-runtime/pom.xml (working copy)
@@ -109,5 +109,10 @@
             <groupId>javax.interceptor</groupId>
             <artifactId>javax.interceptor-api</artifactId>
         </dependency>
+ <dependency> <!-- for FindBugs -->
+ <groupId>com.sun.mail</groupId>
+ <artifactId>javax.mail</artifactId>
+ <scope>provided</scope>
+ </dependency>
     </dependencies>
 </project>
Index: nucleus/cluster/admin/pom.xml
===================================================================
--- nucleus/cluster/admin/pom.xml (revision 62735)
+++ nucleus/cluster/admin/pom.xml (working copy)
@@ -149,6 +149,11 @@
             <version>${project.version}</version>
             <scope>test</scope>
         </dependency>
+ <dependency> <!-- for FindBugs -->
+ <groupId>org.codehaus.jettison</groupId>
+ <artifactId>jettison</artifactId>
+ <scope>provided</scope>
+ </dependency>
     </dependencies>
 </project>

Index: nucleus/osgi-platforms/osgi-cli-interactive/pom.xml
===================================================================
--- nucleus/osgi-platforms/osgi-cli-interactive/pom.xml (revision 62735)
+++ nucleus/osgi-platforms/osgi-cli-interactive/pom.xml (working copy)
@@ -81,6 +81,13 @@
             <scope>provided</scope>
             <optional>true</optional>
         </dependency>
+ <dependency> <!-- for FindBugs -->
+ <groupId>org.fusesource.hawtjni</groupId>
+ <artifactId>hawtjni-runtime</artifactId>
+ <version>1.5</version>
+ <scope>provided</scope>
+ <optional>true</optional>
+ </dependency>
     </dependencies>

     <build>
Index: nucleus/admin/rest/rest-service/pom.xml
===================================================================
--- nucleus/admin/rest/rest-service/pom.xml (revision 62735)
+++ nucleus/admin/rest/rest-service/pom.xml (working copy)
@@ -131,6 +131,11 @@
             <artifactId>security</artifactId>
             <version>${project.version}</version>
         </dependency>
+ <dependency> <!-- for FindBugs -->
+ <groupId>org.osgi</groupId>
+ <artifactId>org.osgi.core</artifactId>
+ <scope>provided</scope>
+ </dependency>
     </dependencies>
     <build>
         <plugins>
Index: nucleus/security/ssl-impl/pom.xml
===================================================================
--- nucleus/security/ssl-impl/pom.xml (revision 62735)
+++ nucleus/security/ssl-impl/pom.xml (working copy)
@@ -74,6 +74,12 @@
             <artifactId>common-util</artifactId>
             <version>${project.version}</version>
         </dependency>
+ <dependency> <!-- for FindBugs -->
+ <groupId>org.glassfish.main.common</groupId>
+ <artifactId>simple-glassfish-api</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
+ </dependency>
         <dependency>
             <groupId>org.glassfish.hk2</groupId>
             <artifactId>core</artifactId>
Index: nucleus/security/core/pom.xml
===================================================================
--- nucleus/security/core/pom.xml (revision 62735)
+++ nucleus/security/core/pom.xml (working copy)
@@ -225,6 +225,12 @@
             <artifactId>glassfish-api</artifactId>
             <version>${project.version}</version>
         </dependency>
+ <dependency> <!-- for FindBugs -->
+ <groupId>org.glassfish.main.common</groupId>
+ <artifactId>simple-glassfish-api</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
+ </dependency>
         <dependency>
             <groupId>org.glassfish.main.external</groupId>
             <artifactId>ldapbp-repackaged</artifactId>