Looks good
On 5/6/13 3:07 PM, Mason Taube wrote:
>
>
> Begin forwarded message:
>
>> *From: *Mason Taube <mason.taube_at_oracle.com
>> <mailto:mason.taube_at_oracle.com>>
>> *Subject: **Fwd: pom review*
>> *Date: *May 3, 2013 10:19:26 AM EDT
>> *To: *"dev_at_glassfish.java.net <mailto:dev_at_glassfish.java.net>"
>> <dev_at_glassfish.java.net <mailto:dev_at_glassfish.java.net>>
>> *Cc: *"romain.grecourt_at_oracle.com <mailto:romain.grecourt_at_oracle.com>
>> Grecourt" <romain.grecourt_at_oracle.com
>> <mailto:romain.grecourt_at_oracle.com>>
>> *Reply-To: *dev_at_glassfish.java.net <mailto:dev_at_glassfish.java.net>
>>
>>
>>
>> Begin forwarded message:
>>
>>> *From: *Mason Taube <mason.taube_at_oracle.com
>>> <mailto:mason.taube_at_oracle.com>>
>>> *Subject: **pom review*
>>> *Date: *May 2, 2013 11:52:32 AM EDT
>>> *To: *dev_at_glassfish.java.net <mailto:dev_at_glassfish.java.net>
>>> *Reply-To: *dev_at_glassfish.java.net <mailto:dev_at_glassfish.java.net>
>>>
>>> An old version of the cdi-api was being included in
>>> embedded-glassfish causing java.lang.NoSuchMethodError at app
>>> deployment time.
>>>
>>> I made this dependency optional as well because the javax.* packages
>>> are included in the weld-osgi-bundle that we provide.
>>>
>>> --
>>> $ svn diff
>>> Index: appserver/pom.xml
>>> ===================================================================
>>> --- appserver/pom.xml(revision 61789)
>>> +++ appserver/pom.xml(working copy)
>>> @@ -77,7 +77,7 @@
>>> <javax.transaction-api.version>1.2</javax.transaction-api.version>
>>> <jaxws-api.version>2.2.8</jaxws-api.version>
>>> <javax.faces-api.version>2.2-m12</javax.faces-api.version>
>>> - <cdi-api.version>1.1-PRD</cdi-api.version>
>>> + <cdi-api.version>1.1</cdi-api.version>
>>> <javax.inject.version>1</javax.inject.version>
>>> <javax.resource-api.version>1.7</javax.resource-api.version>
>>> <javax.enterprise.deploy-api.version>1.6</javax.enterprise.deploy-api.version>
>>> Index: appserver/web/gf-weld-connector/pom.xml
>>> ===================================================================
>>> --- appserver/web/gf-weld-connector/pom.xml(revision 61789)
>>> +++ appserver/web/gf-weld-connector/pom.xml(working copy)
>>> @@ -73,6 +73,7 @@
>>> <dependency>
>>> <groupId>javax.enterprise</groupId>
>>> <artifactId>cdi-api</artifactId>
>>> + <optional>true</optional>
>>> </dependency>
>>> </dependencies>
>>> </project>
>>>
>>
>