Hi Amy,
It looks fine.
I have two comments:
- remove the groupId as it's the same as the parent.
- remove <relativePath>../pom.xml</relativePath> as it's the default
value.
Thanks,
Romain
On 09/21/2012 02:21 AM, Amy Roh wrote:
> Hi,
>
> I'd like to add a parent pom file that builds all, web and nucleus
> embedded modules. The same pom.xml exists in 3.1.2, however, it is
> missing in the trunk.
>
> Index: appserver/extras/embedded/pom.xml
> ===================================================================
> --- appserver/extras/embedded/pom.xml (revision 0)
> +++ appserver/extras/embedded/pom.xml (revision 0)
> @@ -0,0 +1,61 @@
> +<?xml version="1.0" encoding="UTF-8"?>
> +<!--
> +
> + DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
> +
> + Copyright (c) 1997-2012 Oracle and/or its affiliates. All rights
> reserved.
> +
> + The contents of this file are subject to the terms of either the GNU
> + General Public License Version 2 only ("GPL") or the Common
> Development
> + and Distribution License("CDDL") (collectively, the "License"). You
> + may not use this file except in compliance with the License. You can
> + obtain a copy of the License at
> + https://glassfish.dev.java.net/public/CDDL+GPL_1_1.html
> + or packager/legal/LICENSE.txt. See the License for the specific
> + language governing permissions and limitations under the License.
> +
> + When distributing the software, include this License Header
> Notice in each
> + file and include the License file at packager/legal/LICENSE.txt.
> +
> + GPL Classpath Exception:
> + Oracle designates this particular file as subject to the "Classpath"
> + exception as provided by Oracle in the GPL Version 2 section of
> the License
> + file that accompanied this code.
> +
> + Modifications:
> + If applicable, add the following below the License Header, with
> the fields
> + enclosed by brackets [] replaced by your own identifying information:
> + "Portions Copyright [year] [name of copyright owner]"
> +
> + Contributor(s):
> + If you wish your version of this file to be governed by only the
> CDDL or
> + only the GPL Version 2, indicate your decision by adding
> "[Contributor]
> + elects to include this software in this distribution under the
> [CDDL or GPL
> + Version 2] license." If you don't indicate a single choice of
> license, a
> + recipient has the option to distribute your version of this file
> under
> + either the CDDL, the GPL Version 2 or to extend the choice of
> license to
> + its licensees as provided above. However, if you add GPL Version
> 2 code
> + and therefore, elected the GPL Version 2 license, then the option
> applies
> + only if the new code is made subject to such option by the copyright
> + holder.
> +
> +-->
> +
> +<project xmlns="http://maven.apache.org/POM/4.0.0"
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/maven-v4_0_0.xsd">
> + <modelVersion>4.0.0</modelVersion>
> + <parent>
> + <groupId>org.glassfish.main.extras</groupId>
> + <artifactId>extras</artifactId>
> + <version>4.0-SNAPSHOT</version>
> + <relativePath>../pom.xml</relativePath>
> + </parent>
> + <groupId>org.glassfish.main.extras</groupId>
> + <artifactId>embedded</artifactId>
> + <packaging>pom</packaging>
> + <name>GlassFish Embedded modules</name>
> + <modules>
> + <module>all</module>
> + <module>nucleus</module>
> + <module>web</module>
> + </modules>
> +</project>