dev@glassfish.java.net

Re: osgi.bundle review request

From: Marina Vatkina <marina.vatkina_at_oracle.com>
Date: Thu, 29 Mar 2012 18:08:34 -0700

I have not checked in yet. But I did 'svn cp' when I moved most of the
existing file content to the new location. 'svn mv --force' doesn't work
on a non-committed structure.

thanks,
-marina

Sahoo wrote:
> I don't understand what you mean here. If you have not added checked
> this in, then you could just move the dir using fileystem command, no?
> Otherwise, see if svn mv --force helps.
>
> Sahoo
> On Friday 30 March 2012 06:15 AM, Marina Vatkina wrote:
>> Can I do it in 2 step process? svn doesn't allow me to move a dir
>> that wasn't added.
>>
>> thanks,
>> -marina
>>
>> Sahoo wrote:
>>> I think you should change the pkg name to
>>> org.glassfish.common.util.timer before checking in.
>>>
>>> Sahoo
>>> On Friday 30 March 2012 06:06 AM, Marina Vatkina wrote:
>>>> Jane, Sahoo,
>>>>
>>>> Please review changes to the nucleus/common/common-util/osgi.bundle
>>>> export list. The new package in the export list will contain the
>>>> common TimerSchedule class that will be extended by the EJB
>>>> Container and any other module that needs extra features.
>>>>
>>>> Index: nucleus/common/common-util/osgi.bundle
>>>> ===================================================================
>>>> --- nucleus/common/common-util/osgi.bundle (revision 53229)
>>>> +++ nucleus/common/common-util/osgi.bundle (working copy)
>>>> @@ -71,6 +71,7 @@
>>>> org.glassfish.admin.payload; \
>>>> org.glassfish.common.util.admin; \
>>>> org.glassfish.quality; \
>>>> + org.glassfish.timer; \
>>>> org.glassfish.security.common; \
>>>> com.sun.logging.enterprise.system.core; \
>>>> org.glassfish.server;
>>>> version=${project.osgi.version}
>>>>
>>>>
>>>> thanks,
>>>> -marina
>>>
>