Thank you for verifying this. The changes look good.
Jane
On 2/2/12 1:29 PM, Cheng Fang wrote:
> appserver/packager/glassfish-common/pom.xml already contains
> glassfish-naming before my change.
>
> After building with the these changes, glassfish-naming.jar is in
> glassfish/modules directory. I also verified that nucleus.zip no
> longer contains glassfish-naming.jar.
>
> Thanks,
> -cheng
>
> On 2/2/12 4:15 PM, Jane Young wrote:
>> You're moving glassfish-naming from nucleus to appserver. Is this
>> module added in appserver/packager module? Is it added via
>> transitional dependency?
>>
>> Thanks,
>> Jane
>>
>>
>> On 2/2/12 11:52 AM, Cheng Fang wrote:
>>> Please review the following changes for moving glassfish-naming
>>> module out of nucleus to appserver:
>>> (issue http://java.net/jira/browse/GLASSFISH-17489 )
>>>
>>> appserver/common/pom.xml
>>> nucleus/common/pom.xml
>>> nucleus/packager/nucleus-common/pom.xml
>>>
>>> Thanks,
>>> -cheng
>>>
>>