dev@glassfish.java.net

Payload and PayloadImpl Changes

From: Jason Lee <jason.d.lee_at_oracle.com>
Date: Thu, 09 Feb 2012 10:35:03 -0600

Tim, I need to be able to return binary files via REST calls. To do
this, given the use of ActionReport, etc., I need to make a small change
to the public API of Payload. The diff for the change is below. Do you
see any issues with this change?

Thanks!

Index:
nucleus/common/common-util/src/main/java/org/glassfish/admin/payload/PayloadImpl.java
===================================================================
---
nucleus/common/common-util/src/main/java/org/glassfish/admin/payload/PayloadImpl.java
(revision 52514)
+++
nucleus/common/common-util/src/main/java/org/glassfish/admin/payload/PayloadImpl.java
(working copy)
@@ -52,8 +52,10 @@
  import java.net.URI;
  import java.net.URLConnection;
  import java.util.ArrayList;
+import java.util.Collection;
  import java.util.Collections;
  import java.util.Iterator;
+import java.util.List;
  import java.util.Properties;
  import java.util.logging.Logger;
  import org.glassfish.api.admin.Payload;
@@ -335,7 +337,8 @@
              return (isComplex()) ? getComplexContentType() :
getSinglePartContentType();
          }

- ArrayList<Payload.Part> getParts() {
+ @Override
+ public Collection<Payload.Part> getParts() {
              return parts;
          }

Index:
nucleus/common/glassfish-api/src/main/java/org/glassfish/api/admin/Payload.java
===================================================================
---
nucleus/common/glassfish-api/src/main/java/org/glassfish/api/admin/Payload.java
(revision 52514)
+++
nucleus/common/glassfish-api/src/main/java/org/glassfish/api/admin/Payload.java
(working copy)
@@ -46,6 +46,7 @@
  import java.io.InputStream;
  import java.io.OutputStream;
  import java.net.URI;
+import java.util.Collection;
  import java.util.Iterator;
  import java.util.Properties;

@@ -147,6 +148,8 @@
                  final Properties props,
                  final String content) throws IOException;

+ public Collection<Payload.Part> getParts();
+
          /**
           * Adds a part of the specified content type, name, and
content to
           * the payload.

-- 
Jason Lee
Senior Member of Technical Staff
GlassFish Team
Oracle Corporation
Phone +1 405-216-3193
Blog http://blogs.steeplesoft.com