Looks fine to me...
Thanks,
Snjezana
----- Original Message -----
From: shing.wai.chan_at_oracle.com
To: dev_at_glassfish.dev.java.net
Sent: Tuesday, September 13, 2011 2:55:40 PM GMT -08:00 US/Canada Pacific
Subject: Code review for pom.xml
I would like to move WebContainerStarter from nucleus/core/kernel to
appserver/core/javaee-kernel
(from package com.sun.enterprise.v3.services.impl;
to package org.glassfish.kernel.javaee;)
And I need to change the following pom.xml
Please let me know if it is ok.
main/appserver/core/javaee-kernel $ svn diff pom.xml
Index: pom.xml
===================================================================
--- pom.xml (revision 49477)
+++ pom.xml (working copy)
@@ -86,5 +86,10 @@
<groupId>org.glassfish.hk2</groupId>
<artifactId>hk2</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.glassfish.core</groupId>
+ <artifactId>kernel</artifactId>
+ <version>${project.version}</version>
+ </dependency>
</dependencies>
</project>
Shing Wai Chan