dev@glassfish.java.net

Re: How do I change what ends up in the "modules" dir?

From: Shing Wai Chan <shing.wai.chan_at_oracle.com>
Date: Fri, 09 Sep 2011 11:28:45 -0700

The changes looks good to me.
Shing Wai Chan

>>>>>> On Thu, 8 Sep 2011 15:01:44 -0700 (PDT), Snjezana Sevo-Zenzerovic<snjezana.sevozenzerovic_at_oracle.com> said:
> SSZ> So, you updated packager/glassfish-jsf/pom.xml dependencies to
> SSZ> include new jar, correct?
>
> [...]
>
> SSZ> dependency. You can send me resulting tree.log file and I'll take a
> SSZ> look.
>
> Once we discovered the fighterfish link, your timely suggestion saved
> the day.
>
> Please find attached the changebundle.
>
> I would really like a close review from Snjezana, Jane, and Shing-Wai.
>
> As I said, I did run quicklook and the admingui on this, and those both
> ran well, but even so, I want to make sure I didn't miss anything. I
> did go over the diff very carefully and found a few thing while doing
> so, such as a missing closing % in the windows batch file, and a missing
> . in the Class-Path but it stands to reason that if I missed such things
> twice, I way have missed them more than twice.
>
> Ed
>