Packager changes look fine except for a very tiny nit...
Please don't change JSF version in packager/resources/pkg_conf.py file to "2.1.3,0-0" - in IPS world this version would be lower than the current one so package updates won't behave as expected. You can either leave the current value in place or rev up the build number as you see fit.
Thanks,
Snjezana
----- Original Message -----
From: edward.burns_at_oracle.com
To: dev_at_glassfish.java.net
Sent: Thursday, September 8, 2011 7:56:50 PM GMT -08:00 US/Canada Pacific
Subject: Re: How do I change what ends up in the "modules" dir?
>>>>> On Thu, 8 Sep 2011 15:01:44 -0700 (PDT), Snjezana Sevo-Zenzerovic <snjezana.sevozenzerovic_at_oracle.com> said:
SSZ> So, you updated packager/glassfish-jsf/pom.xml dependencies to
SSZ> include new jar, correct?
[...]
SSZ> dependency. You can send me resulting tree.log file and I'll take a
SSZ> look.
Once we discovered the fighterfish link, your timely suggestion saved
the day.
Please find attached the changebundle.
I would really like a close review from Snjezana, Jane, and Shing-Wai.
As I said, I did run quicklook and the admingui on this, and those both
ran well, but even so, I want to make sure I didn't miss anything. I
did go over the diff very carefully and found a few thing while doing
so, such as a missing closing % in the windows batch file, and a missing
. in the Class-Path but it stands to reason that if I missed such things
twice, I way have missed them more than twice.
Ed
--
| edward.burns_at_oracle.com | office: +1 407 458 0017
| homepage: | http://ridingthecrest.com/
| 12 business days until JSF 2.2 Early Draft Review
| 16 business days until JavaOne 2011