On Monday 19 July 2010 10:59 PM, Byron Nevins wrote:
>
>
> On 7/18/2010 11:30 PM, Jerome Dochez wrote:
>> On 7/18/10 8:01 PM, Byron Nevins wrote:
>>>
>>>
>>> On 7/18/2010 1:31 AM, Jerome Dochez wrote:
>>>> Byron
>>>>
>>>> I believe you added a test in common-util that fail when no network
>>>> connection is present.
>>>>
>>>> testEquals(com.sun.enterprise.util.net.NetUtilsTest)
>>>>
>>>> probably not a good idea to do :
>>>> assertTrue(NetUtils.isEqual("www.oracle.com",
>>>> "www.oracle.com"));
>>>> assertFalse(NetUtils.isEqual("oracle.com", "google.com"));
>>>>
>>>>
>>>> Can u fix this,
>>> Yes -- done.
>> thanks !
>>>
>>>
>>>> and also fix the test that slows down the entire build as reported
>>>> by Sahoo.
>>> No can do. I don't what test slows down his build.
>> I don't think it's particular to his build, mine is pretty slow
>> between those two outputs :
>>
> I've got 45 seconds with no VPN, 52 seconds with no internet connection.
> I can't reproduce any problem.
With the latest workspace which has revision 38801 [1], the time to
build/test common-util has drastically reduced. Now, it takes around 45
seconds, out of which 37 seconds is spent in the test MiniXmlParserTest.
What is that test doing? Why is it taking so long?
Thanks,
Sahoo
[1] r38801 | bnevins | 2010-07-19 07:33:39 +0530 (Mon, 19 Jul 2010) | 3
lines
removed 2 tests that require an internet connection.