dev@glassfish.java.net

Re: pom.xml review request - deployment/admin

From: Jerome Dochez <jerome.dochez_at_oracle.com>
Date: Mon, 12 Jul 2010 14:21:21 -0700

On 7/12/10 11:43 AM, Vijay Ramachandran wrote:
> That will add admin/config-api dependency into common-util. Hence I
> chose admin-util.
>
> Are you OK with adding the config-api dependency to common-util ?
no I think it would be a circular dependency.
>
> Of course, admin/config-api is a small module and may not result in
> too many unnecessary modules getting loaded.
no, let's leave it like this.
>
> Vijay
>
> On 7/12/10 11:36 AM, Jerome Dochez wrote:
>> Should that utility be in the common-util module rather than the
>> admin-util ?
>>
>> jerome
>> On 7/12/10 9:28 AM, Tim Quinn wrote:
>>> Hi.
>>>
>>> This pom change allows the deployment commands to see the new
>>> ClusterOperationUtil class Vijay has added to the admin/util
>>> module. Previously deployment/admin did not depend on this module.
>>>
>>> Thanks.
>>>
>>> - Tim
>>>
>>> Index: pom.xml
>>> ===================================================================
>>> --- pom.xml (revision 38547)
>>> +++ pom.xml (working copy)
>>> @@ -160,5 +160,10 @@
>>> <artifactId>deployment-versioning</artifactId>
>>> <version>${project.version}</version>
>>> </dependency>
>>> + <dependency>
>>> + <groupId>org.glassfish.admin</groupId>
>>> + <artifactId>admin-util</artifactId>
>>> + <version>${project.version}</version>
>>> + </dependency>
>>> </dependencies>
>>> </project>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>