dev@glassfish.java.net

Re: osgi.bundle and pom.xml review request : Connectors, JDBC (CLI)

From: Jagadish Prasath Ramu <Jagadish.Ramu_at_Sun.COM>
Date: Wed, 30 Jun 2010 11:18:57 +0530

Thanks to Sahoo !
There is no need to export the package of the CLI being introduced
(osgi.bundle).

-Jagadish


On Mon, 2010-06-28 at 10:23 +0530, Sanjeeb Sahoo wrote:
> Looks OK. See if you can reorganise code to avoid exporting the new
> package. I understand if this can't be done.
>
> On Monday 28 June 2010 09:47 AM, Jagadish Prasath Ramu wrote:
> > Hi Sahoo, Jane,
> >
> > Please review the following changes to introduce CLIs that will be used
> > by REST (in-turn will be used by GUI) [1]
> >
> > Thanks,
> > -Jagadish
> >
> > [1]
> > Index: jdbc/admin/pom.xml
> > ===================================================================
> > --- jdbc/admin/pom.xml (revision 38152)
> > +++ jdbc/admin/pom.xml (working copy)
> > @@ -120,6 +120,11 @@
> > <artifactId>glassfish-api</artifactId>
> > <version>${project.version}</version>
> > </dependency>
> > +<dependency>
> > +<groupId>org.glassfish.connectors</groupId>
> > +<artifactId>connectors-internal-api</artifactId>
> > +<version>${project.version}</version>
> > +</dependency>
> >
> > Index: jdbc/admin/osgi.bundle
> > ===================================================================
> > --- jdbc/admin/osgi.bundle (revision 38152)
> > +++ jdbc/admin/osgi.bundle (working copy)
> > @@ -1,2 +1,3 @@
> > -exportcontents: \
> > + org.glassfish.jdbc.admin.cli.internal \
> > org.glassfish.jdbc.admin.cli; version=
> > ${project.osgi.version}
> >
> >
> > Index: connectors/admin/osgi.bundle
> > ===================================================================
> > --- connectors/admin/osgi.bundle (revision 38152)
> > +++ connectors/admin/osgi.bundle (working copy)
> > @@ -1,2 +1,3 @@
> > -exportcontents: \
> > + org.glassfish.connectors.admin.cli.internal \
> > org.glassfish.connectors.admin.cli; version=
> > ${project.osgi.version}
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> > For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>