hi all,
Integrated scripts with QL to verify log messages from server.log file.
This script is checking following errors in server.log file.
* Message keys logged instead of message
* Parameter marker not substituted with value
* Bundle not found
* Messages not found in message bundle
* No message
* Messages with common typo's ('occured' with one 'r', 'dont' missing
apostrophe, etc.)
* Messages with double apostrophes
* Messages with no proper message Id
I integrated script in such a way that it wouldn't fail the QL build but
gives you pass and fail error at the end for log messages.
The script is available under quicklook/gfproject/utils.xml. The same
folder contains one more file called log_msg_excl.txt which is used by
utils.xml. This file contains list of messages which needs to be
excluded during above script run. So messages available part of this
file doesn't consider to be error message.
When you run the QL at the end it runs target called
'check-logged-messages'. It lists the messages from server.log file and
based on the error it lists on the console.
When you get this kind of error check the console output if you find
it's from your package/file/module verify those. If you think this error
is irrelevant or part of LocalStrings.properties file put that message
or part of the message in log_msg_excl.txt so next time when you run it
exclude those messages listed under log_msg_excl.txt file. We run test
multiple times and created log_msg_excl.txt file to put all exclude
message lists. I also created multiple bugs based on this and assigned
to different modules.
*What developer needs to do?*
Make sure to check the pass/fail status. If it shows fails verify
console output. If it's part of your module fix the same. If you think
it's need to be part of excluded list then copy under log_msg_excl.txt file.
Let me know if you have any question on the same.
Regards,
Naman
On Friday 25 June 2010 06:39 AM, Ming Zhang wrote:
> I am done with that.
> Thanks,
> Ming
>
> On 6/24/2010 5:00 PM, Marina Vatkina wrote:
>> Ming,
>>
>> Can you please move the end result of the tests pass/fail to the
>> bottom of the output. Otherwise they are lost behind the long list of
>> messages.
>>
>> thanks,
>> -marina
>>
>> Ming Zhang wrote:
>>> Naman integrated the check-logged-message target to QL yesterday.
>>>
>>> Naman, can you add descriptions to section I of
>>> quicklook/QuickLook_Test_Instructions.html for how user should
>>> use/interpreate this target?
>>>
>>> Regards,
>>> Ming
>>>
>>> On 6/24/2010 3:32 PM, Jane Young wrote:
>>>> Okay, I see the check-logged-message target:
>>>>
>>>> check-logged-messages:
>>>> [echo] Checking messages in:
>>>> [echo]
>>>> /BUILD_AREA/workspace/gf-trunk-build-continuous/gfv3-gp/glassfishv3/glassfish/domains/domain1/logs/server.log
>>>>
>>>> [echo] [copy] Copying 1 file to
>>>> /export/home1/java_re/BUILD_AREA/workspace/gf-trunk-build-continuous/v3/tests/test-output
>>>>
>>>> [echo]
>>>> [echo] * Message keys logged instead of message:
>>>> [echo] (none)
>>>> [echo]
>>>>
>>>> Ming, can you answer Marina's question.
>>>>
>>>> Thanks,
>>>> Jane
>>>>
>>>>
>>>> Marina Vatkina wrote:
>>>>> I'm asking what the check-logged-messages test does and how to
>>>>> decipher its output?
>>>>>
>>>>> thanks,
>>>>> -marina
>>>>>
>>>>> Jane Young wrote:
>>>>>> I'm not sure what you're asking. But you can check if QL tests
>>>>>> are passing on Hudson:
>>>>>> http://hudson.glassfish.org/job/gf-trunk-build-continuous/
>>>>>> If Hudson tests are passing and your local QL tests are failing
>>>>>> then it may be related to your changes.
>>>>>>
>>>>>> Marina Vatkina wrote:
>>>>>>> What does its long output mean and how can I check if I broke
>>>>>>> anything?
>>>>>>>
>>>>>>> thanks,
>>>>>>> -marina
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>>
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>>>
>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: quality-unsubscribe_at_glassfish.dev.java.net
>>>> For additional commands, e-mail: quality-help_at_glassfish.dev.java.net
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: quality-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: quality-help_at_glassfish.dev.java.net
>>