Ah ha! I thought I added a test for that! I guess I didn't do it quite
right...
Hong Zhang wrote on 06/11/10 02:47 PM:
> Hi, Ming
> (It did not show up there probably because you did not re-subscribe to
> the dev alias with your oracle email address).
>
> Thanks for looking into this!
>
> Jerome will check in a fix for the problem soon. He will let us know
> once his fix is in. And you can check in your changes the next day (so
> you could verify QL tests pass with the nightly build).
>
> - Hong
>
> On 6/11/2010 5:36 PM, Ming Zhang wrote:
>> Somehow it's not showing up on dev glassfish alias. FYI.
>>
>> -------- Original Message --------
>> Subject: Re: Yesterday's change broke ejb devtests
>> Date: Fri, 11 Jun 2010 14:18:58 -0700
>> From: Ming Zhang <ming.zhang_at_oracle.com>
>> To: dev_at_glassfish.dev.java.net
>> References: <4C127EBC.20608_at_oracle.com> <4C12801B.7010902_at_oracle.com>
>> <4C1286D8.8010001_at_oracle.com> <4C1296C8.6090805_at_oracle.com>
>>
>>
>>
>> Hi Hong,
>>
>> I checked the top level build script and found that the build/deployment
>> target calls the build-deploy from web/helloworld. So I propose to do
>> upload deployment only for this test:
>> quicklook/web/helloworld % svn diff
>> Index: build.xml
>> ===================================================================
>> -<target name="build-deploy" depends="build,deploy" />
>> +<target name="build-deploy" depends="build,deploy-upload" />
>>
>> I tried the above change with the latest build from continuous hudson
>> build and the test failed at deployment. If I check in, the QL will fail
>> also at deployment. Can you verify the change and check in with the
>> deployment fix?
>>
>> Thanks,
>> Ming
>>
>> On 6/11/2010 1:04 PM, Hong Zhang wrote:
>> > Hi, Bill
>> >>>
>> >>> Yes, we have seen the same thing. Seems any DAS deployment with
>> >>> --upload=true was broken and the clustering deployment was also broken
>> >>> (there the --upload is always set to true). Jerome is helping to
>> >>> investigate the cause right now...
>> >>
>> >> I added a quicklook test to test --upload=true, so that should be
>> >> working in at least simple cases. If not, we need to fix the
>> >> quicklook test!
>> > Somehow when we run the whole QL tests from top, these tests are not
>> > being run. When I went to that directory (web/helloworld) and ran all
>> > tests there, I saw the same failure:
>> >
>> > deploy-upload-v3-impl:
>> > [echo] deploying hellojsp.war with --upload
>> >
>> > deploy-upload-v3-impl-unix:
>> > [exec] remote failure: Unknown plain text format. Response from
>> > the server: {0}
>> > [exec] Command deploy failed.
>> > [exec] Result: 1
>> >
>> > Ming: can you take a look to see why these deploy-upload tests were
>> > not being run if we ran the tests from the top?
>> >
>> > Thanks,
>> >
>> > - Hong
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail:dev-unsubscribe_at_glassfish.dev.java.net
>> > For additional commands, e-mail:dev-help_at_glassfish.dev.java.net
>> >
>>
>>