dev@glassfish.java.net

[v3.1 action] Re: Amended review request (was Re: Review request: appclient/acc pom.xml revision (v3.1))

From: Tim Quinn <Timothy.Quinn_at_Sun.COM>
Date: Thu, 17 Dec 2009 17:35:22 -0600

Could someone review the revised pom please?

Thanks.

- Tim

Tim Quinn wrote:
> I have made one further change in this pom (I had not checked in the
> earlier-approved change yet).
>
> In addition to the earlier change (adding the jaxb implementation to
> as a runtime dependency), I've now removed the explicit version
> setting for the dependency on the corba module. The version is
> specified in the dependency-management section of the master pom and
> should not appear here again.
>
> Thanks.
>
> - Tim
>
> Index: pom.xml
> ===================================================================
> --- pom.xml (revision 35127)
> +++ pom.xml (working copy)
> @@ -383,7 +383,6 @@
> <dependency>
> <groupId>com.sun.corba</groupId>
> <artifactId>glassfish-corba-orb</artifactId>
> - <version>${acc.corba-version}</version>
> </dependency>
>
> <dependency>
> @@ -492,10 +491,18 @@
>
> <!-- endorsed: jaxb-api-osgi.jar -->
> <dependency>
> + <scope>runtime</scope>
> <groupId>javax.xml.bind</groupId>
> <artifactId>jaxb-api-osgi</artifactId>
> </dependency>
>
> + <!-- GlassFish-delivered version jaxb-osgi.jar -->
> + <dependency>
> + <scope>runtime</scope>
> + <groupId>com.sun.xml.bind</groupId>
> + <artifactId>jaxb-osgi</artifactId>
> + </dependency>
> +
> <!-- endorsed: webservices-api-osgi.jar -->
> <dependency>
> <groupId>javax.xml</groupId>
>